Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gRPC version and a way to override protoc-os-classifier #18992

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Bump gRPC version and a way to override protoc-os-classifier #18992

merged 1 commit into from
Jul 27, 2021

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Jul 26, 2021 •
edited
Loading

this change does three things:

  • upgrades grpc libs
  • adds support for optional fields in proto files
  • adds a way to override the OS classifier for protoc

fixes #16451

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC labels Jul 26, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 71d0a10

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@michalszynkiewicz michalszynkiewicz force-pushed the bump-grpc-and-custom-os-classifier branch from 71d0a10 to e59eadd Compare July 26, 2021 13:05
@michalszynkiewicz michalszynkiewicz mentioned this pull request Jul 26, 2021
Closed
@michalszynkiewicz michalszynkiewicz force-pushed the bump-grpc-and-custom-os-classifier branch from e59eadd to 1dd29ef Compare July 26, 2021 20:21
@michalszynkiewicz michalszynkiewicz requested review from mkouba and removed request for cescoffier July 26, 2021 21:03
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 27, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1dd29ef

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/oidc-code-flow

✖ io.quarkus.it.keycloak.CodeFlowTest.testIdTokenInjectionWithoutRestoredPath line 403 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/web-app/callback-after-redirect?state=0c42bc51-26cd-48b3-af78-261b03c9259e&session_state=b819f366-fe8c-43a6-9c59-91e5aeba652f&code=93992248-fb09-44d3-93a6-0d6c17944e4d.b819f366-fe8c-43a6-9c59-91e5aeba652f.38bfc465-493f-49cd-8f4a-7b2f81b945a5
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:919)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1041)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1071)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1002)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElemen...

@michalszynkiewicz
Copy link
Member Author

The CodeFlowTest looks unrelated. @sberyozkin is this something that fails occasionally?

mkouba
mkouba approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 27, 2021

Failing Jobs - Building 1dd29ef

Status Name Step Test failures Logs Raw logs
⌛ MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@michalszynkiewicz michalszynkiewicz merged commit 964f4d9 into quarkusio:main Jul 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC
Projects
None yet
Milestone
2.2.0.CR1
Development

Successfully merging this pull request may close these issues.

Support for Proto3 Optional Fields
2 participants
@michalszynkiewicz @mkouba