Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for relative alternate POM resolution #18985

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Better support for relative alternate POM resolution #18985

merged 1 commit into from
Jul 28, 2021

Conversation

aloubyansky
Copy link
Member

Fixes #18981

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/testing labels Jul 26, 2021
@aloubyansky aloubyansky mentioned this pull request Jul 26, 2021
Closed
@famod
Copy link
Member

famod commented Jul 26, 2021

@aloubyansky the Maven tests are not happy.

@aloubyansky aloubyansky force-pushed the relative-alternate-pom branch from 5c93291 to 4a4d775 Compare July 26, 2021 11:17
@aloubyansky
Copy link
Member Author

The tests were trying to add commons-io:commons-io:2.6 that was already present in the template project, for which I removed the version because it's managed by the quarkus-bom (to avoid another version being download). So I changed it to commons-codec which is also managed in the quarkus-bom but isn't present in the template project.

@aloubyansky aloubyansky merged commit 079c389 into quarkusio:main Jul 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 28, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/testing
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.

Alternate pom.xml ignored in Quarkus Dev mode and Tests if not specified with an absolute path
4 participants
@aloubyansky @famod @gastaldi @gsmet