Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Narayana getting initialized in static init #18984

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Stop Narayana getting initialized in static init #18984

merged 1 commit into from
Jul 26, 2021

Conversation

stuartwdouglas
Copy link
Member

This stops it being runtime configurable, and also loads the XML parsers
in JVM mode.

@stuartwdouglas stuartwdouglas requested a review from Sanne July 26, 2021 06:30
@quarkus-bot quarkus-bot bot added the area/narayana Transactions / Narayana label Jul 26, 2021
@stuartwdouglas
Copy link
Member Author

@Sanne this was partially introduced here: 89abf61

I don't understand that commit, the two methods in question are @ApplicationScoped, which means they will only be called a single time by ArC.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b1de0b5

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/narayana-jta/deployment

✖ io.quarkus.narayana.interceptor.TransactionalTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor#build threw an exception: java.lang.RuntimeException: unable to load properties from jar:file:/home/runner/.m2/repository/org/jboss/narayana/jta/narayana-jta/5.12.0.Final/narayana-jta-5.12.0.Final.jar!/jbossts-properties.xml
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getPropertiesFromFile(AbstractPropertiesFactory.java:107)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.initDefaultProperties(AbstractPropertiesFactory.java:196)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getDefaultProperties(AbstractPropertiesFactory.java:62)
	at com.arjuna.common.util.propertyservice.PropertiesFactory.getDefaultProperties(PropertiesFactory.java:48)
	at io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor.build(Narayan...

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/narayana-jta/deployment

✖ io.quarkus.narayana.interceptor.TransactionalTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor#build threw an exception: java.lang.RuntimeException: unable to load properties from jar:file:/C:/Users/runneradmin/.m2/repository/org/jboss/narayana/jta/narayana-jta/5.12.0.Final/narayana-jta-5.12.0.Final.jar!/jbossts-properties.xml
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getPropertiesFromFile(AbstractPropertiesFactory.java:107)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.initDefaultProperties(AbstractPropertiesFactory.java:196)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getDefaultProperties(AbstractPropertiesFactory.java:62)
	at com.arjuna.common.util.propertyservice.PropertiesFactory.getDefaultProperties(PropertiesFactory.java:48)
	at io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor.buil...

⚙️ JVM Tests - JDK 16 #

📦 extensions/narayana-jta/deployment

✖ io.quarkus.narayana.interceptor.TransactionalTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor#build threw an exception: java.lang.RuntimeException: unable to load properties from jar:file:/home/runner/.m2/repository/org/jboss/narayana/jta/narayana-jta/5.12.0.Final/narayana-jta-5.12.0.Final.jar!/jbossts-properties.xml
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getPropertiesFromFile(AbstractPropertiesFactory.java:107)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.initDefaultProperties(AbstractPropertiesFactory.java:196)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getDefaultProperties(AbstractPropertiesFactory.java:62)
	at com.arjuna.common.util.propertyservice.PropertiesFactory.getDefaultProperties(PropertiesFactory.java:48)
	at io.quarkus.narayana.jta.deployment.NarayanaJtaProcessor.build(Narayan...

@stuartwdouglas
Stop Narayana getting initialized in static init
cbf9a7e 
This stops it being runtime configurable, and also loads the XML parsers
in JVM mode.
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jul 26, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2021

Failing Jobs - Building cbf9a7e

Status Name Step Test failures Logs Raw logs
⌛ Native Tests - Spring Download Maven Repo ⚠️ Check → Logs Raw logs

Sanne
Sanne reviewed Jul 26, 2021
View reviewed changes
...narayana-jta/deployment/src/test/java/io/quarkus/narayana/interceptor/TransactionalTest.java
import io.quarkus.test.QuarkusUnitTest;

public class TransactionalTest {

static final Set<String> loadedClasses = Collections.newSetFromMap(new ConcurrentHashMap<>());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was later replaced with your nice new testing helper?

It's not used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@Sanne Sanne merged commit dcf7c09 into quarkusio:main Jul 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 26, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/narayana Transactions / Narayana
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartwdouglas @Sanne @gsmet