Dev UI - ArC - add interceptors page #18967

mkouba · 2021-07-23T12:27:24Z

also display associated interceptors on the "beans" page

mkouba · 2021-07-23T12:29:04Z

This reminds me that we should remove unused interceptors as well... I'll try to prepare a separate PR.

mkouba · 2021-07-23T12:30:35Z

The new page looks like:

geoand

Good idea! I added a couple suggestions

extensions/arc/deployment/src/main/resources/dev-templates/beans.html

geoand · 2021-07-23T12:31:32Z

extensions/arc/deployment/src/main/resources/dev-templates/interceptors.html

+  {#title}Interceptors{/title}
+  {#body}
+  <div class="alert alert-primary alert-dismissible fade show" role="alert" data-timer="30000">
+    Interceptors are sorted by the interceptor class in ascending order. However, application interceptors go first. 


Wouldn't it make sense to sort by priorioty?

Agree that this would make a lot of sense, but I think that showing application interceptors more prominently than platform/external ones also makes sense.

Maybe they should instead have a different color or some marker?

I am definitely no UI expert, so I have no idea what the best representation should be...

So right now we use isApplicationClass and then interceptorClass name. We could probably change this to isApplicationClass and then priority name and then interceptorClass name...

Maybe they should instead have a different color or some marker?

They do - application classes are links that can be opened in your IDE... except it does not work for me ;-).

I have never been able to test Eclipse for this. A little while ago, @FroMage did and it worked for him

quarkus-bot · 2021-07-23T15:40:50Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `279425d`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/devmode

✖ io.quarkus.test.devconsole.DevConsoleArcSmokeTest.testPages line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "io.quarkus.test.devconsole.DevConsoleArcSmokeTest$Foo#onStr"
  Actual: <!DOCTYPE html>
<html lang="en">
    <head>
        <!-- Required meta tags -->
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

        <!-- Bootstrap CSS -->
        <link rel="stylesheet" href="/q/dev/resources/css/bootstrap.min.css">
        <link rel="stylesheet" href="/q/dev/resources/fontawesome/css/all.min.css">
        <link rel="stylesheet" href="/q/dev/resources/css/dev-console.css?2">
        <link rel="stylesheet" href="/q/dev/resources/css/logstream.css">
        <link rel="stylesheet" href="/q/dev/resources/css/tests.css">
        <link rel="shortcut icon" type="image/png" href="/q/dev/resources/images/favicon.ico" >

        <style>
            
   .annotation {
     color: gray;
     font-style: itali...

📦 integration-tests/main

✖ io.quarkus.it.main.GreetingProfileTestCase.testPortTakesEffect - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.jaeger.deployment.JaegerProcessor#setupTracer threw an exception: java.lang.ArrayIndexOutOfBoundsException: Index 21 out of bounds for length 15
	at java.base/java.util.ArrayList.add(ArrayList.java:487)
	at java.base/java.util.ArrayList.add(ArrayList.java:499)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.addCloseTask(QuarkusClassLoader.java:538)
	at io.quarkus.deployment.recording.BytecodeRecorderImpl.getRecordingProxy(BytecodeRecorderImpl.java:345)
	at io.quarkus.deployment.ExtensionLoader.lambda$loadStepsFromClass$78(ExtensionLoader.java:647)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:816)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(Enh...

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/devmode

✖ io.quarkus.test.devconsole.DevConsoleArcSmokeTest.testPages line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "io.quarkus.test.devconsole.DevConsoleArcSmokeTest$Foo#onStr"
  Actual: <!DOCTYPE html>
<html lang="en">
    <head>
        <!-- Required meta tags -->
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

        <!-- Bootstrap CSS -->
        <link rel="stylesheet" href="/q/dev/resources/css/bootstrap.min.css">
        <link rel="stylesheet" href="/q/dev/resources/fontawesome/css/all.min.css">
        <link rel="stylesheet" href="/q/dev/resources/css/dev-console.css?2">
        <link rel="stylesheet" href="/q/dev/resources/css/logstream.css">
        <link rel="stylesheet" href="/q/dev/resources/css/tests.css">
        <link rel="shortcut icon" type="image/png" href="/q/dev/resources/images/favicon.ico" >

        <style>
            
   .annotation {
     color: gray;
     font-style: itali...

- also display associated interceptors on the "beans" page

quarkus-bot · 2021-07-24T12:04:35Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c2e35b3`

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

✖ io.quarkus.jaxrs.client.reactive.deployment.test.UniInvokerTestCase.testInjection line 49 - More details - Source on GitHub

java.lang.IllegalStateException: Client request did not complete
	at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.close(RestClientRequestContext.java:251)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:187)
	at org.jboss.resteasy.reactive.client.impl.AsyncInvokerImpl.performRequestInternal(AsyncInvokerImpl.java:260)
	at org.jboss.resteasy.reactive.client.impl.AsyncInvokerImpl.performRequestInternal(AsyncInvokerImpl.java:251)
	at org.jboss.resteasy.reactive.client.impl.AsyncInvokerImpl.method(AsyncInvokerImpl.java:218)
	at org.jboss.resteasy.reactive.client.impl.UniInvoker$1.get(UniInvoker.java:24)
	at org.jboss.resteasy.reactive.client.impl.UniInvoker$1.get(UniInvoker.java:21)
	at io.smallrye.context.impl.wrappers.SlowContextualSupplier.get(SlowContextualSupplier.java:21)
	at io.smallrye.mutiny.operators.uni.builders.UniCreateFromCompletionStage.subscribe(UniCreateFromCompletionStage.java:24)
	...

Ladicek

Can't comment much on the HTML templates, but overall looks fine.

quarkus-bot · 2021-07-26T12:54:56Z

Failing Jobs - Building `c2e35b3`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Native Tests - Data1	`Build`	⚠️ Check →	Logs	Raw logs
❓	Native Tests - Spring		⚠️ Check →

mkouba · 2021-07-26T13:05:21Z

I'm going to merge this PR because the Native Tests - Data1 CI job failed with:

 Caused by: io.fabric8.maven.docker.access.DockerAccessException: error pulling image configuration: Get https://eastus.data.mcr.microsoft.com/aba285c624a04409823b708c7a50e7b9-jttfjm99vo//docker/registry/v2/blobs/sha256/c0/c04a8093cf1b8806b8b614117d958b4a30975ad21960043943ae3ef801d815f2/data?P1=1627295559&P2=1&P3=1&P4=GbvO7HlPhRWm4rcPBgwsYPMxCATmAI3Zv7kH0XVBwl4%3D&se=2021-07-26T10%3A32%3A39Z&sig=TW8yJ9Du9SO7BF4Sf5q%2BXd57oPkLpkbPLKKtLCFVTEk%3D&sp=r&spr=https&sr=b&sv=2016-05-31&regid=aba285c624a04409823b708c7a50e7b9: dial tcp 204.79.197.219:443: i/o timeout

quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jul 23, 2021

mkouba requested review from geoand, gwenneg and Ladicek July 23, 2021 12:28

geoand reviewed Jul 23, 2021

View reviewed changes

Dev UI - ArC - add interceptors page

c2e35b3

- also display associated interceptors on the "beans" page

mkouba force-pushed the devui-arc-interceptors branch from 279425d to c2e35b3 Compare July 24, 2021 08:52

geoand approved these changes Jul 26, 2021

View reviewed changes

Ladicek approved these changes Jul 26, 2021

View reviewed changes

gwenneg approved these changes Jul 26, 2021

View reviewed changes

mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 26, 2021

mkouba merged commit 5d3db73 into quarkusio:main Jul 26, 2021

quarkus-bot bot added this to the 2.2 - main milestone Jul 26, 2021

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev UI - ArC - add interceptors page #18967

Dev UI - ArC - add interceptors page #18967

mkouba commented Jul 23, 2021

mkouba commented Jul 23, 2021

mkouba commented Jul 23, 2021

geoand left a comment

geoand Jul 23, 2021

Ladicek Jul 23, 2021

geoand Jul 23, 2021

mkouba Jul 23, 2021

mkouba Jul 23, 2021

geoand Jul 23, 2021

quarkus-bot bot commented Jul 23, 2021 •

edited

Loading

Failing Jobs - Building `279425d`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/devmode

📦 integration-tests/main

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/devmode

quarkus-bot bot commented Jul 24, 2021 •

edited

Loading

Failing Jobs - Building `c2e35b3`

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

Ladicek left a comment

quarkus-bot bot commented Jul 26, 2021

mkouba commented Jul 26, 2021

Dev UI - ArC - add interceptors page #18967

Dev UI - ArC - add interceptors page #18967

Conversation

mkouba commented Jul 23, 2021

mkouba commented Jul 23, 2021

mkouba commented Jul 23, 2021

geoand left a comment

Choose a reason for hiding this comment

geoand Jul 23, 2021

Choose a reason for hiding this comment

Ladicek Jul 23, 2021

Choose a reason for hiding this comment

geoand Jul 23, 2021

Choose a reason for hiding this comment

mkouba Jul 23, 2021

Choose a reason for hiding this comment

mkouba Jul 23, 2021

Choose a reason for hiding this comment

geoand Jul 23, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Jul 23, 2021 • edited Loading

Failing Jobs - Building 279425d

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/devmode

📦 integration-tests/main

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/devmode

quarkus-bot bot commented Jul 24, 2021 • edited Loading

Failing Jobs - Building c2e35b3

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

Ladicek left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jul 26, 2021

Failing Jobs - Building c2e35b3

mkouba commented Jul 26, 2021

quarkus-bot bot commented Jul 23, 2021 •

edited

Loading

Failing Jobs - Building `279425d`

quarkus-bot bot commented Jul 24, 2021 •

edited

Loading

Failing Jobs - Building `c2e35b3`

Failing Jobs - Building `c2e35b3`