-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to GraalVM 21.2 #18932
Bump to GraalVM 21.2 #18932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks. And nice catch for using the attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, I think this should be upgraded too: https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java#L19
4a56e14
to
8fd302d
Compare
Good catch, this was left out of date since 21.0! |
Hmmmm Spring-Web is not happy
I wonder how it worked on the nightlies with 21.2-dev :/ I'll have a closer look |
I can't reproduce locally:
I am using the same branch "bump-to-graalvm-21.2". |
Is anyone working on this? Would be great to be able to upgrade. |
I can't reproduce this locally either. Running |
Interesting. I've trriggered a new CI build some ~3 hours ago, should be close to completion soon. I'll check it locally as well. |
Actually "Native Tests - Spring" already completed, and that's the one which previously failed. |
That's great! |
It worked for me locally as well. WDYT @gsmet , can we take the risk of introducing a flaky test? I think we should try, as far as I understood from our earlier conversation it's even possible that this test is already flakey on the current VM version, issues with |
Although it won't get to the root of the problem, we can always remove the XML part from this test... It's not terrible important to test anyway.... |
But let's see if it ever fails again - and there's chances if this very rare that |
You definitely have my vote |
We can merge and see how it goes. I'm afraid there might be something non deterministic lurking but we will see. |
In the end, we cannot backport it: it causes issues with Camel JS DSL component and with the Google Cloud Services extension. /cc @loicmathieu @ppalaga |
Marking it for backport again so that we can see if we can consider it for the next backport run. |
GraalVM builder images are ready, the Mandrel ones are to appear soon.
Note: there are is no Java16 release of GraalVM CE 21.2 yet, it's expected sometime next week.