Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassLoader leak #18926

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix ClassLoader leak #18926

merged 1 commit into from
Jul 22, 2021

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@Sanne
Copy link
Member

Sanne commented Jul 22, 2021

Looks good, but I also noticed that often the QuarkusClassloader isn't actually closed, so is this going to be fired?

(I don't know how it happens, I have only seen several QuarkusClassloader in heap dumps which have the closed boolean set to false - maybe a false alarm as I've not figured out yet if what I'm observing if this is a legit situation)

@Sanne Sanne merged commit 86f9b20 into quarkusio:main Jul 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 22, 2021
@stuartwdouglas
Copy link
Member Author

@Sanne it should be closed, are you sure you are not seeing the active CL for the currently running tests?

Also sometimes the CL is supposed to last the life of the test run, depending on the type of tests.

@Sanne
Copy link
Member

Sanne commented Jul 22, 2021

Thanks, I'll double check tomorrow.

I'm fairly sure I saw more than one QuarkusClassloader open, but now that you explained in a parallel conversation about the CL and Vertx instances needed for dev-ui that might explain it.

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants