Avoid trying to set permissions on the cache directory on windows #18867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
previously requested changes
Jul 20, 2021
...nsions/vertx-core/runtime/src/main/java/io/quarkus/vertx/core/runtime/VertxCoreRecorder.java
Outdated
Show resolved
Hide resolved
FWIW, WSL2 Ubuntu reports |
|
I don't have Windows with WSL around to double check this :/ |
cescoffier
force-pushed
the
fix-windows-cache-directory-warning
branch
from
7b51196 to
4a52216
Compare
gsmet
reviewed
Jul 21, 2021
| if (!os.contains("windows")) { | ||
| // Do not execute the following on windows. | ||
| if (!(tmp.setReadable(true, false) && tmp.setWritable(true, false))) { | ||
| LOGGER.warnf("Unable to make the Vert.x cache directory (%s) world readable and writable", |
There was a problem hiding this comment.
Unrelated question but why are we trying to make it world writable? Shouldn't it be only writable by the current user? Am I missing something?
There was a problem hiding this comment.
There is a structure. The first level is world writable as multiple Quarkus app started by multiple users will write into it. The nested level is limited to the user.
rsvoboda
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16895
@rsvoboda This is the approach not trying to set the permission on windows. However, not sure it works on Windows using the WSL emulation.