-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Dev Console smoke test for Keycloak #18856
Add a Dev Console smoke test for Keycloak #18856
Conversation
@@ -215,7 +215,7 @@ private DevServicesConfigBuildItem prepareConfiguration(boolean createRealm, | |||
private StartResult startContainer() { | |||
if (!capturedDevServicesConfiguration.enabled) { | |||
// explicitly disabled | |||
LOG.error("Not starting devservices for Keycloak as it has been disabled in the config"); | |||
LOG.debug("Not starting devservices for Keycloak as it has been disabled in the config"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was debug
in my original copy of a similar code but I changed it to error
while I was looking at some PR problem and forgot to change it back
Hmm, it tries to start a KC dev services container. I thought I disabled it, @mkouba, does the smoke test setup looks correct to you ? |
@mkouba I'm also not sure if I should go through all |
6b1965e
to
660a681
Compare
660a681
to
e2d20ae
Compare
I've double checked it and on my laptop the container is not starting - though I had to update one unit test in |
I've cancelled the build as I've realized I had to disable KC dev services for all the |
e2d20ae
to
b6e333c
Compare
OK, it should be better now, I've disabled it for all the tests at the pom level |
b6e333c
to
35fd05d
Compare
@phillip-kruger thanks, will also wait for Martin to check |
Looks like Martin is off, so I'll merge it then, I've verified locally as well that no container is started; the templates fixes are necessary in any case and we can do more as needed (I've run through the main page in a quickstart - all seems fine for now); Martin - please let me know when you get a chance if something else has to be improved :-) |
Also
Fixes #18853.
(please backport together with #17364 if #17364 is backported)