Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dev Console smoke test for Keycloak #18856

Merged

Conversation

sberyozkin
Copy link
Member

Also
Fixes #18853.

(please backport together with #17364 if #17364 is backported)

@@ -215,7 +215,7 @@ private DevServicesConfigBuildItem prepareConfiguration(boolean createRealm,
private StartResult startContainer() {
if (!capturedDevServicesConfiguration.enabled) {
// explicitly disabled
LOG.error("Not starting devservices for Keycloak as it has been disabled in the config");
LOG.debug("Not starting devservices for Keycloak as it has been disabled in the config");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was debug in my original copy of a similar code but I changed it to error while I was looking at some PR problem and forgot to change it back

@sberyozkin
Copy link
Member Author

sberyozkin commented Jul 20, 2021

Hmm, it tries to start a KC dev services container. I thought I disabled it, @mkouba, does the smoke test setup looks correct to you ?

@sberyozkin
Copy link
Member Author

@mkouba I'm also not sure if I should go through all provider.html and also embedded.html and update all the references to various info properties with ?? even those inside the scripts/etc ? May be it is simpler to register them as null if devservices for KC are disabled ? It works though for now

@sberyozkin sberyozkin marked this pull request as draft July 20, 2021 13:24
@sberyozkin sberyozkin force-pushed the dev_console_keycloak_smoke_test branch from 6b1965e to 660a681 Compare July 20, 2021 13:26
@sberyozkin sberyozkin marked this pull request as ready for review July 20, 2021 14:13
@sberyozkin sberyozkin force-pushed the dev_console_keycloak_smoke_test branch from 660a681 to e2d20ae Compare July 20, 2021 14:15
@sberyozkin
Copy link
Member Author

I've double checked it and on my laptop the container is not starting - though I had to update one unit test in integration-tests/devmode to ensure OIDC will not attempt to connect in a non-dev mode

@sberyozkin
Copy link
Member Author

sberyozkin commented Jul 20, 2021

I've cancelled the build as I've realized I had to disable KC dev services for all the devmode tests - this is a problem with enabling by default - but at least there are only a few of these tests are there

@sberyozkin sberyozkin force-pushed the dev_console_keycloak_smoke_test branch from e2d20ae to b6e333c Compare July 20, 2021 15:04
@sberyozkin
Copy link
Member Author

sberyozkin commented Jul 20, 2021

OK, it should be better now, I've disabled it for all the tests at the pom level

@sberyozkin sberyozkin force-pushed the dev_console_keycloak_smoke_test branch from b6e333c to 35fd05d Compare July 20, 2021 15:06
@sberyozkin
Copy link
Member Author

@phillip-kruger thanks, will also wait for Martin to check

@sberyozkin
Copy link
Member Author

Looks like Martin is off, so I'll merge it then, I've verified locally as well that no container is started; the templates fixes are necessary in any case and we can do more as needed (I've run through the main page in a quickstart - all seems fine for now); Martin - please let me know when you get a chance if something else has to be improved :-)

@sberyozkin sberyozkin merged commit fa6cd08 into quarkusio:main Jul 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 21, 2021
@sberyozkin sberyozkin deleted the dev_console_keycloak_smoke_test branch July 21, 2021 07:54
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling Dev Services For Keycloak causes a template exception due to a strict rendering
3 participants