Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - improved error when unable to add a synthetic no-arg constructor #18805

Merged
merged 1 commit into from
Jul 19, 2021
Merged

ArC - improved error when unable to add a synthetic no-arg constructor #18805

merged 1 commit into from
Jul 19, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 19, 2021

@mkouba
ArC - improved error when unable to add a synthetic no-arg constructor
bde03df 
- QuarkusUnitTest - make it easy to log/debug the expected exception
- resolves quarkusio#18592
@mkouba mkouba requested review from manovotn and famod July 19, 2021 11:40
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/testing labels Jul 19, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Jul 19, 2021

An error message now looks like:

javax.enterprise.inject.spi.DeploymentException: It's not possible to automatically add a synthetic no-args constructor to an unproxyable bean class. You need to manually add a non-private no-args constructor to io.quarkus.arc.test.unproxyable.FailedToAddMissingNoargsConstructorTest$MyBean in order to fulfill the requirements for normal scoped/intercepted/decorated beans.

manovotn
manovotn approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mkouba mkouba merged commit df12275 into quarkusio:main Jul 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 19, 2021
@famod
Copy link
Member

famod commented Jul 19, 2021

Thanks! This message makes it very clear what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@famod famod Awaiting requested review from famod

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/testing
Projects
None yet
Milestone
2.2.0.CR1
Development

Successfully merging this pull request may close these issues.

ArC: Make error on missing superclass no-arg constructor more user friendly
3 participants
@mkouba @famod @manovotn