Fix split packages issue in Hibernate ORM with Panache #18743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list is incomplete for now but we will add the others after fixing each issue.
For now, only deprecate the old annotation, it will be removed in 2.2.
quarkus-bot
bot
added
area/arc
loicmathieu
approved these changes
Jul 16, 2021
Comment on lines
96
to
+106
| if (parameter.isAnnotationPresent(ProjectedFieldName.class)) { | ||
| final String name = parameter.getAnnotation(ProjectedFieldName.class).value(); | ||
| if (name.isEmpty()) | ||
| if (name.isEmpty()) { | ||
| throw new PanacheQueryException("The annotation ProjectedFieldName must have a non-empty value."); | ||
| } | ||
| parameterName = name; | ||
| } else if (parameter.isAnnotationPresent(io.quarkus.hibernate.orm.panache.ProjectedFieldName.class)) { | ||
| final String name = parameter.getAnnotation(io.quarkus.hibernate.orm.panache.ProjectedFieldName.class).value(); | ||
| if (name.isEmpty()) { | ||
| throw new PanacheQueryException("The annotation ProjectedFieldName must have a non-empty value."); | ||
| } |
There was a problem hiding this comment.
You could have squashed these two if on the same condition using an ||, this would avoid the small code duplication.
There was a problem hiding this comment.
Well not really as I get the value from a different annotation. I think it's good enough as it is given we will drop one of the branch in 2.2.
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.