Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP Reference Guide #18717

Merged
merged 2 commits into from
Jul 19, 2021
Merged

AMQP Reference Guide #18717

merged 2 commits into from
Jul 19, 2021

Conversation

cescoffier
Copy link
Member

No description provided.


include::{generated-dir}/config/quarkus-smallrye-reactive-messaing-amqp.adoc[opts=optional, leveloffset=+1]

=== Incoming channel configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these properties defined somewhere else? Asking because this could easily drift

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of, they are generated from the list of @ConnectorAttribute in the connector.
We have an annotation processor generating this table.
So, the only task is to copy/paste the table when we update (if we changed the attributes).

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions/typo fixes.

docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved

== Receiving AMQP messages

Let's imagine, your application receives `Message<Double>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Let's imagine, your application receives `Message<Double>`.
Let's imagine your application receives `Message<Double>`.

docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
To send messages to RabbitMQ:

* set the destination address (anonymous sender are not supported)
* set use-anonymous-sender to false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* set use-anonymous-sender to false
* set `use-anonymous-sender` to false

docs/src/main/asciidoc/amqp-reference.adoc Outdated Show resolved Hide resolved
@cescoffier cescoffier force-pushed the amqp-reference-guide branch from bd39e42 to a1f2f36 Compare July 19, 2021 06:57
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2021
@gsmet gsmet merged commit c6d7796 into quarkusio:main Jul 19, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 19, 2021
@cescoffier cescoffier deleted the amqp-reference-guide branch July 19, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants