Register @ConfigMappings directly into the Config builder

[radcortez]

• Fixes Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Initial work to register the mappings directly with the builder.

• Requires an update in SR Config (Update SmallRye Config to 2.4.2 #18629)
• Requires the registration for static init (Register ConfigSources directly with the builder #17483)

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 6ddda8f

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	CI Sanity Check	Build	⚠️ Check →	Logs	Raw logs

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5590255

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 16

[gsmet]

I rebased it as it was a bit old.

[gsmet]

I wonder if we should just deprecate the old one for 2.2? Or we are sure it's not used anywhere in our extension ecosystem?

(deprecating a build item is easy, you just consume the old ones and produce the new ones)

[radcortez]

I think it is ok to rename, this is only intended for internal usage.

This raises an interesting question. Do we have a way to distinguish which build step may be used safely on the ecosystem and which are for internal only? Unfortunately, a regular access modifier is not enough.

[gsmet]

No, we don't.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 6b405a0

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.simple.SimpleQuarkusRestTestCase.testFilters line 141 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting ArrayList:
  []
to contain only:
  ["authentication-authorization-default"]
but could not find the following element(s):
  ["authentication-authorization-default"]

	at io.quarkus.resteasy.reactive.server.test.simple.SimpleQuarkusRestTestCase.testFilters(SimpleQuarkusRestTestCase.java:141)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:363)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:331)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.ju...

[gsmet]

@radcortez can you please ping me here when this is ready, I keep forgetting about it. Thanks!

[radcortez]

@radcortez can you please ping me here when this is ready, I keep forgetting about it. Thanks!

Yes, it is ready, I've just rebased with main.

[marcelstoer]

@radcortez

Should this now also allow for constructor injection of configs into a an exception mapper? I was getting the same error as reported in #18333 with my exception mapper below.

@Provider
@ApplicationScoped
class RouteExceptionInterceptor(config: MyConfig) : ExceptionMapper<Exception> {

Since I found this I bumped Quarkus to 2.2.0.CR1. The app still does not start but the config error is now different. Hence, I was wondering if this indicates this issue is not fully fixed yet OR whether I am having a different problem.

Should this now also allow for constructor injection of configs into a an exception mapper?

Yes, this PR fixes this as well. Thanks!

[radcortez]

Yes

@radcortez

Should this now also allow for constructor injection of configs into a an exception mapper? I was getting the same error as reported in #18333 with my exception mapper below.

@Provider
@ApplicationScoped
class RouteExceptionInterceptor(config: MyConfig) : ExceptionMapper<Exception> {

Since I found this I bumped Quarkus to 2.2.0.CR1. The app still does not start but the config error is now different. Hence, I was wondering if this indicates this issue is not fully fixed yet OR whether I am having a different problem.

Should this now also allow for constructor injection of configs into a an exception mapper?

Yes, this PR fixes this as well. Thanks!

Yes, but unfortunately we need to revert this because it is creating other issues: #19937