Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --tests option to --skip-tests in Quarkus CLI #18438

Closed
wants to merge 2 commits into from
+1 −1
Closed

Rename --tests option to --skip-tests in Quarkus CLI #18438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83031d2
Fix for #18391, changing the CLI options
tqvarnst Jul 6, 2021
35394e2
Merge branch 'quarkusio:main' into main
tqvarnst Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devtools/cli/src/main/java/io/quarkus/cli/common/BuildOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class BuildOptions {
@CommandLine.Option(order = 5, names = { "--offline" }, description = "Work offline.", defaultValue = "false")
public boolean offline = false;

@CommandLine.Option(order = 6, names = { "--tests" }, description = "Run tests.", negatable = true)
@CommandLine.Option(order = 6, names = { "--skip-tests" }, description = "Skip tests.")
public boolean runTests = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the meaning of this property be changed too? I suspect it won't work as is (or I might miss how Picocli is working as I have no experience with it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this change. I am on PTO, but I would prefer to make the options as they exist work (which I thought I had tests for, but apparently not...).


public boolean skipTests() {
Expand Down