-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce valid JSON for Multi<String> return type in RESTEasy Reactive #18344
Conversation
- also add integration-tests/resteasy-reactive
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Thanks! Ping me when you are ready for a review |
Ping! :-) |
Thanks for this! I would prefer if the PR didn't introduce a whole new project just for testing. |
Hmm, I tried to move some of the tests to the
|
I would suggest the following:
see https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#workflow-tips for more details |
Sorry, I messed up my fork. Had to re-create one and open a new PR. Please see #18401. |
This is primarily meant to provide a fix for #18043. However, there were no
integration-tests/resteasy-reactive
yet, so I added them. I have a few questions with you to discuss:Regarding my fix for the issue in
StreamingUtil.java
...MediaType
condition?FullyFeaturedServerJacksonMessageBodyWriter
; however, I wasn't sure how to test that for side-effects; probably running the RESTeasy TCK?Regarding the integration tests for RESTeasy reactive
I added the project right under
integration-tests
and copied (YUK!) some classes from theresteasy-mutiny
andresteasy-jackson
integration tests. Would be better to share the classes, using a parent or shared project. However, I was not sure how much restructuring I would be allowed to do in this scope. You might like to have this done under a separate GitHub issue?