Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes version selection for non-platform extensions when the stream is not specified #18003

Merged

Conversation

aloubyansky
Copy link
Member

I'll need to enhance the testing framework to be able to add proper tests for these use-case. In the meantime though I was using the following commands to test the issues

quarkus create datadog-opentracing minio kogito-quarkus-rules --registry-client -e should result in

    <quarkus.platform.artifact-id>quarkus-universe-bom</quarkus.platform.artifact-id>
    <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
    <quarkus.platform.version>1.13.7.Final</quarkus.platform.version>
    <surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
  </properties>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>${quarkus.platform.artifact-id}</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>org.kie.kogito</groupId>
      <artifactId>kogito-quarkus-rules</artifactId>
    </dependency>
    <dependency>
      <groupId>io.quarkiverse.minio</groupId>
      <artifactId>quarkus-minio</artifactId>
    </dependency>
    <dependency>
      <groupId>io.quarkiverse.opentracing.datadog</groupId>
      <artifactId>quarkus-datadog-opentracing</artifactId>
      <version>1.0.0</version>
    </dependency>

quarkus create datadog-opentracing minio --registry-client -e should result in

    <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
    <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
    <quarkus.platform.version>2.0.0.CR3</quarkus.platform.version>
    <surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
  </properties>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>${quarkus.platform.artifact-id}</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>io.quarkiverse.minio</groupId>
      <artifactId>quarkus-minio</artifactId>
      <version>2.0.0.CR3</version>
    </dependency>
    <dependency>
      <groupId>io.quarkiverse.opentracing.datadog</groupId>
      <artifactId>quarkus-datadog-opentracing</artifactId>
      <version>2.0.0</version>
    </dependency>

NOTE: I did modify the version of quarkus-datadog-opentracing in the .m2/repository/io/quarkus/registry/quarkus-non-platform-extensions/1.0-SNAPSHOT/quarkus-non-platform-extensions-1.0-SNAPSHOT-2.0.0.CR3.json to 2.0.0 just to have a different version in the 2.0 stream.

@aloubyansky aloubyansky requested a review from gastaldi June 18, 2021 10:37
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 18, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 18, 2021

Failing Jobs - Building 7768158

Status Name Step Test failures Logs Raw logs
Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

@aloubyansky aloubyansky merged commit 9c1c33e into quarkusio:main Jun 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 18, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants