Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI guide with missing emojis #17994

Merged
merged 1 commit into from Jun 18, 2021
Merged

Update CLI guide with missing emojis #17994

merged 1 commit into from Jun 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2021

@ebullient There is another occurence of the emojis in the CLI guide. This is a PR to also update these.

@ghost
Copy link
Author

ghost commented Jun 18, 2021

@ebullient @gastaldi
FYI, the monkey emoji would work properly. And TBH, the quarkus emoji is very boring. Why not use e.g. 🚀 which is also displayed nicely.

@ebullient
Copy link
Member

sure. go ahead and fix with others that are flashier if you feel compelled.

@ebullient ebullient merged commit fe865db into quarkusio:main Jun 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 18, 2021
@ebullient
Copy link
Member

I made an adjustment in this PR: #18013 (rocketship)
Not a fan of the monkey, personally.
And I think I got both places in the docs correctly w/ that.

@ghost ghost deleted the update-cli-with-emojis branch June 19, 2021 05:46
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@ebullient @gsmet