Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OTEL Vertx Adapter extract forwarded headers for client ip if present #17958

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

luneo7
Copy link
Contributor

@luneo7 luneo7 commented Jun 16, 2021

This PR makes OTEL Vertx Adpater extract the client IP from the de facto forwarded headers (Forwarded && X-Forwarded-For) and if none of them are present it resorts to the remote address from the http request.
Solves #17612

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2021

/cc @kenfinnigan

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building c43f169

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs

@luneo7 luneo7 mentioned this pull request Jun 16, 2021
@kenfinnigan kenfinnigan added this to the 2.1 - main milestone Jun 16, 2021
@kenfinnigan kenfinnigan merged commit 43cf24d into quarkusio:main Jun 16, 2021
@kenfinnigan
Copy link
Member

Thanks!

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants