-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different emoji for project create #17955
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ebullient Just as a reminder: do not forget to also update the CLI guide with the new icons. |
Done. Including a note that the emoji may not match exactly, and may not (in fact) be rendered at all. IntelliJ has some long-running issues re: correct rendering of emoji in the console. (e.g. my terminal in linux is fine, terminal and intellij on mac is fine, terminal in intellij on linux is not.. and there are open issues for intellij about emoji in the terminal, so I'm not inclined to fuss overmuch about it) |
Resolves #17876