Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different emoji for project create #17955

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Use different emoji for project create #17955

merged 1 commit into from
Jun 18, 2021

Conversation

ebullient
Copy link
Member

Resolves #17876

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 16, 2021
@ebullient ebullient changed the title use different emoji for project create Use different emoji for project create Jun 16, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ab3ff2c

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@ebullient ebullient requested a review from maxandersen June 16, 2021 18:21
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost
Copy link

ghost commented Jun 17, 2021

@ebullient Just as a reminder: do not forget to also update the CLI guide with the new icons.

@ebullient
Copy link
Member Author

@ebullient Just as a reminder: do not forget to also update the CLI guide with the new icons.

Done. Including a note that the emoji may not match exactly, and may not (in fact) be rendered at all. IntelliJ has some long-running issues re: correct rendering of emoji in the console. (e.g. my terminal in linux is fine, terminal and intellij on mac is fine, terminal in intellij on linux is not.. and there are open issues for intellij about emoji in the terminal, so I'm not inclined to fuss overmuch about it)

@maxandersen maxandersen added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2021
@ebullient ebullient merged commit 4237cbd into quarkusio:main Jun 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 18, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 18, 2021
@ebullient ebullient deleted the cli-emoji branch June 18, 2021 04:00
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus CLI does not display icons correctly
4 participants