Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take 'enable' field into account for named logging handlers #17914

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Take 'enable' field into account for named logging handlers #17914

merged 1 commit into from
Jun 15, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 15, 2021

Fixes: #17913

@geoand geoand mentioned this pull request Jun 15, 2021
Merged
@geoand geoand requested a review from gastaldi June 15, 2021 13:24
gastaldi
gastaldi approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi merged commit 99fbfab into quarkusio:main Jun 15, 2021
@gastaldi gastaldi deleted the #17913 branch June 15, 2021 13:41
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 15, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
@jotjeeven
Copy link

jotjeeven commented Jul 1, 2021 •
edited
Loading

@geoand
This issue is still reproducible in 2.0.0.Final, Kindly check

@geoand
Copy link
Contributor Author

geoand commented Jul 1, 2021

Can you attach an example application?
When I tried this, it worked just fine, so if it doesn't work for you, an example application is the best way to check

@jotjeeven
Copy link

@geoand Verified the same, it is working fine, Version was not updated at my end, after updation it is working well.
Thanks !!

@geoand
Copy link
Contributor Author

geoand commented Jul 2, 2021

Great, thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/core area/logging
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.

Named logging handlers can't be disabled
4 participants
@geoand @jotjeeven @gastaldi @gsmet