Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Failed to index' warnings for arrays from entities #17890

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix 'Failed to index' warnings for arrays from entities #17890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/JpaJandexScavenger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ private void addClassHierarchyToReflectiveList(Collector collector, DotName clas
// we need to check for enums
for (FieldInfo fieldInfo : classInfo.fields()) {
Type fieldType = fieldInfo.type();
if (Type.Kind.PRIMITIVE == fieldType.kind()) {
if (Type.Kind.CLASS != fieldType.kind()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this would also skip parameterized types. I don't know if it could be a problem in the context of hibernate extension... just saying.

Copy link
Member

@yrodiere yrodiere Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop is about registering enum types for reflection. I don't think an enum can even be parameterized? Even if it can, I don't think the code below would work.

Regardless... I'm sure there are problems with this code (I mean the whole class), in particular with complex models involving generics. IMO our best way forward is to just avoid the need for registering types for reflection. Which is something we've been working on :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok np, I didn't know it's for enums only ;-)

// skip primitives and arrays
continue;
}
DotName fieldClassName = fieldInfo.type().name();
Expand Down