-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support constructor injection into providers #17787
Support constructor injection into providers #17787
Conversation
2a35d63
to
d512120
Compare
This workflow status is outdated as a new workflow run has been triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
d512120
to
e5b19df
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building d512120
|
@stuartwdouglas @geoand Could it be that there is a stale warning in
|
Yes, that warning is longer valid. Mind removing it? |
Your request was registered at queue position 174828. 🤪 |
Oops, I saw the email and decided to fix it, but did not check GH (as based on your comment I did not think you were going to work on this). I think my approach is better though, as you still need an @Inject constructor. |
Sure, if that's the case (and ArC auto-@Inject isn't working here) then your PR should be merged instead! |
ah, I forgot about auto inject. Lets just go with your PR |
No description provided.