Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constructor injection into providers #17787

Merged

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@stuartwdouglas stuartwdouglas force-pushed the resteasy-ctor-injection branch from 2a35d63 to d512120 Compare June 9, 2021 06:35
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 2a35d63

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@stuartwdouglas stuartwdouglas force-pushed the resteasy-ctor-injection branch from d512120 to e5b19df Compare June 9, 2021 06:57
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building d512120

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Set up JDK 11 ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Download Maven Repo ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Amazon ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data2 Build ⚠️ Check → Logs Raw logs
Native Tests - Data3 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - Data5 Build ⚠️ Check → Logs Raw logs
Native Tests - Data6 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data7 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Main Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 9, 2021

Failing Jobs - Building e5b19df

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

@stuartwdouglas stuartwdouglas merged commit 524f250 into quarkusio:main Jun 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 9, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
@famod
Copy link
Member

famod commented Jul 1, 2021

@stuartwdouglas @geoand Could it be that there is a stale warning in ResteasyCommonProcessor after this change? In CI there is the same warning as in my current project:

[INFO] Running io.quarkus.resteasy.test.CustomExceptionMapperTestCase
2021-06-09 07:21:04,664 WARN  [io.qua.res.com.dep.ResteasyCommonProcessor] (build-4) Classes annotated with @Provider should have a single, no-argument constructor, otherwise dependency injection won't work properly. Offending class is io.quarkus.resteasy.test.CustomExceptionMapperTestCase$CustomExceptionMapper

@geoand
Copy link
Contributor

geoand commented Jul 1, 2021

Yes, that warning is longer valid.

Mind removing it?

@famod
Copy link
Member

famod commented Jul 1, 2021

Your request was registered at queue position 174828. 🤪

@stuartwdouglas
Copy link
Member Author

#18328

@stuartwdouglas
Copy link
Member Author

Oops, I saw the email and decided to fix it, but did not check GH (as based on your comment I did not think you were going to work on this).

I think my approach is better though, as you still need an @Inject constructor.

@famod
Copy link
Member

famod commented Jul 1, 2021

Sure, if that's the case (and ArC auto-@Inject isn't working here) then your PR should be merged instead!

@stuartwdouglas
Copy link
Member Author

ah, I forgot about auto inject. Lets just go with your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants