Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in name of AdditionalSecuredClassesBuildIem class #17768

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

knutwannheden
Copy link
Contributor

No description provided.

@gsmet
Copy link
Member

gsmet commented Jun 8, 2021

@ppalaga @evacchi I was leaning towards backporting this one to 2.0 but I was wondering if it could be an issue for you?

@knutwannheden
Copy link
Contributor Author

knutwannheden commented Jun 8, 2021

Please also note that this typo is the reason that the build item is not documented here: https://quarkus.io/guides/all-builditems

See https://github.com/quarkusio/quarkus/blob/main/.github/quarkusbuilditemdoc.java#L96

Of course there are also other build items which don't adhere to the naming convention (e.g. Capabilities) or are declared as nested classes, which also won't be documented this way. Reported here: #17770.

@evacchi
Copy link
Contributor

evacchi commented Jun 8, 2021

I don't think we are using this @danielezonca @mariofusco ?

@gastaldi gastaldi merged commit 1ed2a9e into quarkusio:main Jun 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
@knutwannheden knutwannheden deleted the build-item-typo branch June 8, 2021 17:59
@danielezonca
Copy link
Contributor

I don't think we are using this @danielezonca @mariofusco ?

I agree, I don't have memory of usage of this item

@ppalaga
Copy link
Contributor

ppalaga commented Jun 9, 2021

Thanks for the heads up, @gsmet! I found zero occurrences of AdditionalSecuredClassesBuildIem in Camel Quarkus, so you are good to go.

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants