Do multipart parsing inside RESTEasyReactive

[stuartwdouglas]

This gives us a lot more flexibility, and allows it to work
with multiple backends.

Fixes #17430

[geoand]

Looking at the PR, I assume this is based on your Undertow code?

[stuartwdouglas]

Yea, the multipart parser is adapted from the Undertow parser. I guess I should copy the tests as well.

[geoand]

Assuming the tests pass (and given the fact that this code has already been battle tested in Undertow), this looks great!

[stuartwdouglas]

Actually the Undertow tests don't really add much more than is already covered by our existing multipart tests.

[geoand]

Should we mark this for backporting to 2.0?

[stuartwdouglas]

Looks like there might be some issues with the TCK, investigating now.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building d9f853d

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Gradle Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	Build	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	Verify	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Cache	Download Maven Repo	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data1	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data2	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data3	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data4	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging1	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security3	Extract Maven Repo	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Windows - hibernate-validator		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 843944a

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	Build	Test failures	Logs	Raw logs
✖	Native Tests - Misc4	Build	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.multipart.LargerThanDefaultFormAttributeMultipartFormInputTest.test line 59 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.multipart.LargerThanDefaultFormAttributeMultipartFormInputTest.test line 59 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.multipart.LargerThanDefaultFormAttributeMultipartFormInputTest.test line 59 - More details - Source on GitHub

[FroMage]

I think the multipart structures exposed via the API changed, no? If that's true we need to update the docs too.

[FroMage]

Sorry I was thinking of the move QuarkusFileUpload -> DefaultFileUpload but it turns out they implement an interface which hasn't moved, so we're good :)

[geoand]

The LargerThanDefaultFormAttributeMultipartFormInputTest test which is relevant seems to be failing