Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cleanDisabled to Flyway configuration #16563

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

tioback
Copy link
Contributor

@tioback tioback commented Apr 15, 2021

Adds cleanDisabled to Flyway configuration.

Fixes #16561.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@tioback tioback changed the title Adds cleanDisabled to Flyway configuration. Fixes #16561. Fix #16561 - Adds cleanDisabled to Flyway configuration. Apr 15, 2021
@tioback tioback changed the title Fix #16561 - Adds cleanDisabled to Flyway configuration. Adds cleanDisabled to Flyway configuration Apr 15, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d9bad8a

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@gastaldi
Copy link
Contributor

Can you please squash your commits before we merge this? Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

🚫 This workflow run has been cancelled.

Failing Jobs - Building f12903e

Status Name Step Test failures Logs Raw logs
Devtools Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Linux Verify dependencies ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Reclaim Disk Space ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Download Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Amazon ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data2 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data3 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data4 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data5 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data6 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Main Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator Install cl.exe ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@geoand
Copy link
Contributor

geoand commented Apr 16, 2021

Thanks for this!

Can you please add a test for this in quarkus-integration-test-flyway as well?
The reason being that we would like to make sure it works in native mode as well

@tioback
Copy link
Contributor Author

tioback commented Apr 16, 2021 via email

@gsmet
Copy link
Member

gsmet commented Apr 16, 2021

@geoand I don't think we mandated a native test for the other options? Or did I miss something? If so, I would leave it at that.

@geoand
Copy link
Contributor

geoand commented Apr 16, 2021

Well, we recently had a case where one of the Liquibase options fail in native.
I would like to avoid repeating that

@gsmet
Copy link
Member

gsmet commented Apr 20, 2021

Sure but this option is about disabling something. So if you configure the native executable to use this option, you are actually not testing something (as we won't generate a second native executable just for that).

@geoand
Copy link
Contributor

geoand commented Apr 20, 2021

To be honest, I hadn't even read the name of the option, so I guess you are right 😉

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge! Thanks!

I will backport it to 1.13.3.Final.

@gsmet gsmet merged commit 98bf638 into quarkusio:main Apr 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cleanDisabled to Flyway configuration
4 participants