-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds cleanDisabled
to Flyway configuration
#16563
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
cleanDisabled
to Flyway configuration. Fixes #16561.cleanDisabled
to Flyway configuration.
cleanDisabled
to Flyway configuration. cleanDisabled
to Flyway configuration
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d9bad8a
|
Can you please squash your commits before we merge this? Thanks! |
🚫 This workflow run has been cancelled. Failing Jobs - Building f12903e
|
Thanks for this! Can you please add a test for this in |
Sure thing. I wasn’t aware of this test before. I’ll try to finish it later
on today.
Em sex., 16 de abr. de 2021 às 03:59, Georgios Andrianakis <
***@***.***> escreveu:
Thanks for this!
Can you please add a test for this in quarkus-integration-test-flyway as
well?
The reason being that we would like to make sure it works in native mode
as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16563 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKOAKP7VDXS7THU72EYU3DTI7N55ANCNFSM43AFA4QQ>
.
--
Enviado do meu telemóvel, o pá!
|
@geoand I don't think we mandated a native test for the other options? Or did I miss something? If so, I would leave it at that. |
Well, we recently had a case where one of the Liquibase options fail in native. |
Sure but this option is about disabling something. So if you configure the native executable to use this option, you are actually not testing something (as we won't generate a second native executable just for that). |
To be honest, I hadn't even read the name of the option, so I guess you are right 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge! Thanks!
I will backport it to 1.13.3.Final.
Adds
cleanDisabled
to Flyway configuration.Fixes #16561.