Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashScopeUtil: handle empty cookie bytes #16536

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Apr 15, 2021

Fixes #16534

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@FroMage FroMage changed the title FlashScopeUtil: fix for #16534 handle empty cookie bytes FlashScopeUtil: handle empty cookie bytes Apr 15, 2021
@mkouba
Copy link
Contributor

mkouba commented Apr 15, 2021

Hm, the exception is gone but no message is displayed...

Handle empty values safer, and clear the cookie after we've read it
@FroMage
Copy link
Member Author

FroMage commented Apr 15, 2021

OK, now the message is displayed :)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

🚫 This workflow run has been cancelled.

Failing Jobs - Building f031c7e

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Verify dependencies ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Build ⚠️ Check → Logs Raw logs
Native Tests - Cache Build ⚠️ Check → Logs Raw logs
Native Tests - Data2 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc1 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc2 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security2 Build ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thanks!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 15, 2021
@mkouba mkouba merged commit 22d6cf3 into quarkusio:main Apr 15, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 15, 2021
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev UI - DevConsolePostHandler.flashMessage() results in EOFException
3 participants