Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case of Kafka ServiceBinding properties #16481

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix case of Kafka ServiceBinding properties #16481

merged 1 commit into from
Apr 13, 2021

Conversation

DuncanDoyle
Copy link
Contributor

@DuncanDoyle DuncanDoyle commented Apr 13, 2021 •
edited by geoand
Loading

Fixes #16477

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

geoand
geoand approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand changed the title Fixes #16477. Quarkus Kafka client uses camelCase binding files. Fix case of Kafka ServiceBinging properties Apr 13, 2021
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 13, 2021
@geoand
Copy link
Contributor

geoand commented Apr 13, 2021

The integration tests are failing - I'll force push a fix soon

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 84bab15

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 11 Windows
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 8 Build Test failures Logs Raw logs
✖ Native Tests - Messaging Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka-snappy

✖ io.quarkus.it.kafka.KafkaSnappyProducerTest.health line 48 - More details - Source on GitHub

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka-snappy

✖ io.quarkus.it.kafka.KafkaSnappyProducerTest.health line 48 - More details - Source on GitHub

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka-snappy

✖ io.quarkus.it.kafka.KafkaSnappyProducerTest.health line 48 - More details - Source on GitHub

⚙️ Native Tests - Messaging #

📦 integration-tests/kafka-snappy

✖ io.quarkus.it.kafka.KafkaSnappyProducerITCase.health - More details - Source on GitHub

@geoand geoand force-pushed the bug/kafkaconnection-service-binding branch from 84bab15 to 7f835ce Compare April 13, 2021 16:51
@geoand geoand force-pushed the bug/kafkaconnection-service-binding branch from 7f835ce to fadc477 Compare April 13, 2021 18:59
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7f835ce

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 11 Windows
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 8 Build Test failures Logs Raw logs
⌛ Native Tests - Messaging Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

Failing Jobs - Building fadc477

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 11 Windows
✖ JVM Tests - JDK 15 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 8 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

@geoand geoand merged commit b289957 into quarkusio:main Apr 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 13, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 13, 2021
@gsmet gsmet changed the title Fix case of Kafka ServiceBinging properties Fix case of Kafka ServiceBinding properties Apr 14, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.2.Final Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/kafka
Projects
None yet
Milestone
1.13.2.Final
Development

Successfully merging this pull request may close these issues.

Quarkus Kafka Client ServiceBinding no longer works with app-services service binding
4 participants
@DuncanDoyle @geoand @cescoffier @gsmet