Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java.lang.Error should rollback the JTA transaction #16459

Merged
merged 1 commit into from
Apr 14, 2021
Merged

java.lang.Error should rollback the JTA transaction #16459

merged 1 commit into from
Apr 14, 2021

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Apr 12, 2021 •
edited
Loading

Fix #16455

@quarkus-bot quarkus-bot bot added the area/narayana Transactions / Narayana label Apr 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 12, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 04ff67a

Status Name Step Test failures Logs Raw logs
⌛ MicroProfile TCKs Tests Verify with Maven ⚠️ Check → Logs Raw logs

@ochaloup ochaloup changed the title [#16455] java.lang.Error should rollback the JTA transaction java.lang.Error should rollback the JTA transaction Apr 13, 2021
@ochaloup ochaloup force-pushed the 16455-error-to-rollback-jta-txn branch from 04ff67a to 01de0ce Compare April 13, 2021 08:11
manovotn
manovotn reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ochaloup would it be possible to also add a test?

@ochaloup ochaloup force-pushed the 16455-error-to-rollback-jta-txn branch from 01de0ce to 8200f12 Compare April 14, 2021 10:17
@ochaloup
Copy link
Contributor Author

@manovotn here we go

@ochaloup ochaloup force-pushed the 16455-error-to-rollback-jta-txn branch from 8200f12 to 80aca3e Compare April 14, 2021 10:20
manovotn
manovotn approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ochaloup!

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 14, 2021
@famod
Copy link
Member

famod commented Apr 14, 2021

Is this backport material?

@gastaldi
Copy link
Contributor

@famod definitely backportable 👍🏻

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 14, 2021

Failing Jobs - Building 80aca3e

Status Name Step Test failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit 8ae7218 into quarkusio:main Apr 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 14, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 14, 2021
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/narayana Transactions / Narayana
Projects
None yet
Milestone
1.13.3.Final
Development

Successfully merging this pull request may close these issues.

JTA CDI should roll-back when intercepted method throws Error
5 participants
@ochaloup @famod @gastaldi @manovotn @gsmet