Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when running HQL queries spanning multiple tables in Hibernate Reactive #15835

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Error when running HQL queries spanning multiple tables in Hibernate Reactive #15835

merged 3 commits into from
Mar 18, 2021

Conversation

DavideD
Copy link
Contributor

@DavideD DavideD commented Mar 18, 2021 •
edited by Sanne
Loading

Fixes #15834

Hibernate Reactive needs a different MultiTableBulkIdStrategy than ORM.

@quarkus-bot quarkus-bot bot added area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels Mar 18, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 18, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@DavideD DavideD changed the title [#15834] Error when running HQL queries spanning multiple tables in Hibernate Reactive Error when running HQL queries spanning multiple tables in Hibernate Reactive Mar 18, 2021
@DavideD DavideD mentioned this pull request Mar 18, 2021
Closed
@Sanne Sanne added this to the 1.14 - main milestone Mar 18, 2021
@Sanne Sanne added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 18, 2021
Sanne
Sanne requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with native compilation. I guess a missing reflective rule for the new strategy? I'll have a look

@Sanne Sanne removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 18, 2021
@DavideD
Copy link
Contributor Author

DavideD commented Mar 18, 2021

There is failure when on CI with native: https://github.com/quarkusio/quarkus/pull/15835/checks?check_run_id=2138462807#step:9:364

Any idea?

@DavideD
Copy link
Contributor Author

DavideD commented Mar 18, 2021

Something is wrong with native compilation. I guess a missing reflective rule for the new strategy? I'll have a look

Thanks

@Sanne Sanne self-requested a review March 18, 2021 12:40
Sanne
Sanne approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work now.

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 18, 2021
@Sanne Sanne merged commit e43fc0a into quarkusio:main Mar 18, 2021
@Sanne Sanne removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 18, 2021
@Sanne
Copy link
Member

Sanne commented Mar 18, 2021

Merged! thanks @DavideD

@gsmet gsmet modified the milestones: 1.14 - main, 1.13.0.Final Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
1.13.0.Final
Development

Successfully merging this pull request may close these issues.

Error when running HQL queries spanning multiple tables in Hibernate Reactive
3 participants
@DavideD @Sanne @gsmet