Make class clickable in Log stream (to open in IDE) #15761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WOW! This is great 💯 ! |
geoand
approved these changes
Mar 16, 2021
geoand
added
the
triage/waiting-for-ci
|
@geoand - getting failures in Kubernetes - Standard for Windows. I am sure it's not related to this PR :) |
|
@phillip-kruger can you do me a favor and rebase the PR onto the latest master? My guess is that the failure will go away |
I'd to CI to verify what I have in mind - that is why I ask :) |
Signed-off-by:Phillip Kruger <[email protected]>
|
Re-based. Let's see ! |
|
@geoand same issue after rebase. I am checking local to see if I can recreate it |
|
@geoand - that specific integration tests builds successful on my Linux box. Any advice how to proceed ? |
cescoffier
added
triage/needs-rebase
|
I'll merge the PR as the test is flakey and had since been disabled on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the classes in the log file clickable, to open the file, at the correct line number, in the user's IDE (if we could detect it)
It also makes some lines in a stacktrace clickable.
Signed-off-by:Phillip Kruger [email protected]