-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Google cloud functions HTTP query params and status code bypass #15620
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Thanks, I'll have a look at the Google Cloud Functions side. @patriot1burke can you have a look at the lambda and azure functions side ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
I wanted to particularly thank you for the tests you added, these are great piece of tests and are very valuable additions.
We'll need @patriot1burke review for the lambda and azure functions part.
Can you update the comment so the two reated issues would be fixed automatically when merging this one ? |
@loicmathieu done |
@patriot1burke could you have a look at this one? I'd like to have it in 1.13. or @matejvasek ? |
@patriot1burke @matejvasek ping? If you don't give a sign of life, I will merge it today given @loicmathieu approved it. |
LGTM. Apologies, I've been out for a few weeks. |
@patriot1burke cool, thanks! Will merge then. |
Merged, thanks @HardNorth ! |
Fixes #15501 and fixes #15510, adds unit-tests for Amazon Lambda, Azure Function, Google Function to ensure this will never be broken again. Amazon Lambda query handling slightly improved