Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Google cloud functions HTTP query params and status code bypass #15620

Merged
merged 6 commits into from
Mar 24, 2021

Conversation

HardNorth
Copy link
Contributor

@HardNorth HardNorth commented Mar 11, 2021

Fixes #15501 and fixes #15510, adds unit-tests for Amazon Lambda, Azure Function, Google Function to ensure this will never be broken again. Amazon Lambda query handling slightly improved

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 11, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/dependencies Pull requests that update a dependency file area/google-cloud-functions labels Mar 11, 2021
@HardNorth HardNorth changed the title Fixes issues #15501 and #15510 (Google cloud functions HTTP query params and status code) Fixes Google cloud functions HTTP query params and status code bypass Mar 11, 2021
@HardNorth HardNorth marked this pull request as draft March 11, 2021 09:03
@loicmathieu
Copy link
Contributor

Thanks, I'll have a look at the Google Cloud Functions side.

@patriot1burke can you have a look at the lambda and azure functions side ?

Base automatically changed from master to main March 12, 2021 15:55
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

I wanted to particularly thank you for the tests you added, these are great piece of tests and are very valuable additions.

We'll need @patriot1burke review for the lambda and azure functions part.

@loicmathieu
Copy link
Contributor

Can you update the comment so the two reated issues would be fixed automatically when merging this one ?
See https://docs.github.com/en/enterprise/2.13/user/articles/closing-issues-using-keywords

@HardNorth
Copy link
Contributor Author

@loicmathieu done

@gsmet
Copy link
Member

gsmet commented Mar 16, 2021

@patriot1burke could you have a look at this one? I'd like to have it in 1.13.

or @matejvasek ?

@gsmet
Copy link
Member

gsmet commented Mar 23, 2021

@patriot1burke @matejvasek ping? If you don't give a sign of life, I will merge it today given @loicmathieu approved it.

@patriot1burke
Copy link
Contributor

LGTM. Apologies, I've been out for a few weeks.

@gsmet
Copy link
Member

gsmet commented Mar 24, 2021

@patriot1burke cool, thanks! Will merge then.

@gsmet gsmet merged commit 56e189e into quarkusio:main Mar 24, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 24, 2021
@gsmet
Copy link
Member

gsmet commented Mar 24, 2021

Merged, thanks @HardNorth !

@HardNorth HardNorth deleted the functions-fix branch March 24, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants