Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that native-sources package results in the configuration as native #15291

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Ensure that native-sources package results in the configuration as native #15291

merged 1 commit into from
Feb 25, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 24, 2021 •
edited
Loading

Furthermore, fail the build when native-sources is requested but the extension
creates its own output

Related to: #15233 (comment)

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 24, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@geoand geoand changed the title Ensure that native-sources package results in the configuration as na… Ensure that native-sources package results in the configuration as native Feb 24, 2021
@geoand geoand mentioned this pull request Feb 24, 2021
Merged
@geoand
Ensure that native-sources package results in the configuration as na…
a90ca4b 
…tive

Furthermore, fail the build when native-sources is requested but the extension
creates its own output

Related to: quarkusio#15233 (comment)
@geoand geoand force-pushed the native-sources-followup branch from d57d27a to a90ca4b Compare February 24, 2021 12:27
@geoand geoand marked this pull request as ready for review February 24, 2021 12:27
stuartwdouglas
stuartwdouglas approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now, but this is really showing off the limitations of quarkus.package.type.

We need something more flexible that allows for compositibility between the different outputs (e.g. native-source is a precursor to native so native should also imply native-source).

This needs a discussion on the dev list though.

@geoand
Copy link
Contributor Author

geoand commented Feb 25, 2021

I think this is ok for now, but this is really showing off the limitations of quarkus.package.type.

We need something more flexible that allows for compositibility between the different outputs (e.g. native-source is a precursor to native so native should also imply native-source).

Do you have something in mind?

@geoand geoand merged commit bfa3208 into quarkusio:master Feb 25, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 25, 2021
@geoand geoand deleted the native-sources-followup branch February 25, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/amazon-lambda area/core area/google-cloud-functions area/hibernate-orm Hibernate ORM area/jaeger area/liquibase area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @stuartwdouglas @jerboaa