Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container image extension conflict hint #13949

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix container image extension conflict hint #13949

merged 1 commit into from
Dec 18, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Dec 17, 2020

Fixes: #13946

@ghost
Copy link

ghost commented Dec 17, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use 'Fix Allow * expression for quarkus:add-extension #1234' in the description instead)
  • title should not start with chore/feat/fix/docs but be a proper sentence

This message is automatically generated by a bot.

@iocanel iocanel requested a review from geoand December 17, 2020 12:52
@iocanel iocanel changed the title fix: (#13946) container image extension conflict hint Fix container image extension conflict hint Dec 17, 2020
@geoand
Copy link
Contributor

geoand commented Dec 17, 2020

Sorry to be obnoxious, but could you squash the commits please?

@gsmet
Copy link
Member

gsmet commented Dec 18, 2020

I wanted to do it but I can't push to your fork so you will have to do it yourself.

@geoand
Copy link
Contributor

geoand commented Dec 18, 2020

Yup, I tried that as well

@ghost ghost added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/hibernate-reactive Hibernate Reactive area/kubernetes area/metrics area/panache area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/rest area/smallrye labels Dec 18, 2020
@iocanel
Copy link
Contributor Author

iocanel commented Dec 18, 2020

@geoand @gsmet: squashed commits. can you have a look now?

@geoand geoand merged commit 1a83ef7 into quarkusio:master Dec 18, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/hibernate-search Hibernate Search area/kubernetes area/metrics area/panache area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/rest area/smallrye
Projects
None yet
Milestone
1.11.0.Beta2
Development

Successfully merging this pull request may close these issues.

Error message about conflicting container image extensions is wrong
3 participants
@iocanel @geoand @gsmet