Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Lambda HTTP native image failure archetype fix #13876

Merged

Conversation

oztimpower
Copy link
Contributor

@oztimpower oztimpower commented Dec 14, 2020

Fix #13692

Native image failure to build archetype

Reproduce:

mvn archetype:generate \
       -DarchetypeGroupId=io.quarkus \
       -DarchetypeArtifactId=quarkus-amazon-lambda-http-archetype \
       -DarchetypeVersion=1.10.3.Final

mvn package -Pnative

Removing fat jar resolves:

  <plugin>
     <groupId>io.quarkus</groupId>
      <artifactId>quarkus-maven-plugin</artifactId>
       <version>${quarkus-plugin.version}</version>

        <configuration>
             <uberJar>true</uberJar>
         </configuration>

    </plugin>

@ghost
Copy link

ghost commented Dec 14, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@ghost ghost added the area/amazon-lambda label Dec 14, 2020
@patriot1burke
Copy link
Contributor

@oztimpower Please resolve conflicts. Thanks for fix.

@oztimpower oztimpower changed the title Remove fat jar from lambda http archetype #13692 Fix #13692 Amazon Lambda HTTP native image failure Dec 15, 2020
@oztimpower oztimpower force-pushed the tp/amazon-lambda-http-pom branch from 8d01626 to fc1846c Compare December 15, 2020 10:31
@ghost ghost added area/arc Issue related to ARC (dependency injection) area/cache area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/elasticsearch area/flyway area/funqy area/gradle Gradle area/graphql area/grpc gRPC area/health area/hibernate-validator Hibernate Validator area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/hibernate-reactive Hibernate Reactive area/infinispan Infinispan area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jbang Issues related to when using jbang.dev with Quarkus area/kafka-streams area/liquibase labels Dec 15, 2020
@gsmet gsmet removed area/mongodb area/mutiny area/narayana Transactions / Narayana area/oidc area/openapi area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy-classic area/scheduler area/security area/smallrye area/spring Issues relating to the Spring integration area/testing area/vault area/vertx triage/invalid This doesn't seem right labels Dec 15, 2020
@gsmet
Copy link
Member

gsmet commented Dec 15, 2020

@patriot1burke is it good for you now? Looks like something that I should backport to 1.10.4.Final that I will release this afternoon.

@gsmet
Copy link
Member

gsmet commented Dec 15, 2020

@oztimpower and just to be sure, we can deploy lambdas that are not fat jars?

@oztimpower
Copy link
Contributor Author

oztimpower commented Dec 15, 2020

The runner jar is built as a Uber jar no matter what, the Pom doesn’t need to specifying it anymore. The corresponding amazon-lambda extension doesn’t require Uber jar in the Pom anymore.

The issue that I observed was that with the legacy Uber jar set it was renaming the jar, adding an original extension to the file name which prevented it being found for native image. The jar that is deployed is not this one, it is the runner, so no, the change has no effect - a fat jar, the runner is deployed to Amazon Lambda, not the original.

@patriot1burke
Copy link
Contributor

Hmmm, I thought I changed this so that fat jar isn't required.

@patriot1burke patriot1burke merged commit 7f626f9 into quarkusio:master Dec 15, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 15, 2020
@oztimpower
Copy link
Contributor Author

Yes that’s what I was trying to say. Fat jar manually specified is no longer required - it was legacy in the Pom (and could be removed).

@gsmet gsmet modified the milestones: 1.11 - master, 1.10.4.Final Dec 15, 2020
@oztimpower oztimpower deleted the tp/amazon-lambda-http-pom branch March 4, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to generate native image
3 participants