-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Lambda HTTP native image failure archetype fix #13876
Amazon Lambda HTTP native image failure archetype fix #13876
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
@oztimpower Please resolve conflicts. Thanks for fix. |
8d01626
to
fc1846c
Compare
@patriot1burke is it good for you now? Looks like something that I should backport to 1.10.4.Final that I will release this afternoon. |
@oztimpower and just to be sure, we can deploy lambdas that are not fat jars? |
The runner jar is built as a Uber jar no matter what, the Pom doesn’t need to specifying it anymore. The corresponding amazon-lambda extension doesn’t require Uber jar in the Pom anymore. The issue that I observed was that with the legacy Uber jar set it was renaming the jar, adding an original extension to the file name which prevented it being found for native image. The jar that is deployed is not this one, it is the runner, so no, the change has no effect - a fat jar, the runner is deployed to Amazon Lambda, not the original. |
Hmmm, I thought I changed this so that fat jar isn't required. |
Yes that’s what I was trying to say. Fat jar manually specified is no longer required - it was legacy in the Pom (and could be removed). |
Fix #13692
Native image failure to build archetype
Reproduce:
Removing fat jar resolves: