IDE dev mode: add only reloadable local dependencies to the devmode context #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area/core
area/devtools
This was referenced Dec 10, 2020
|
There are some sysout calls in Apart from that I confirm that this is (also) fixing this strange incremental/partial build error: #13740 (comment) Great job, our persistence has prevailed! 😁 PS: I didn't test dev mode with this change. Maybe you @glefloch want to check the Gradle side of things? |
|
I can run some test tomorrow yes :) |
aloubyansky
force-pushed
the
ide-devmode-only-reloadable-deps
branch
from
88cc785 to
3bd8763
Compare
glefloch
reviewed
Dec 11, 2020
aloubyansky
force-pushed
the
ide-devmode-only-reloadable-deps
branch
from
3bd8763 to
d6a820b
Compare
gsmet
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the investigations performed by @famod. Thanks a lot for your great efforts, @famod!
The IDE dev mode should be using only the re-loadable local dependencies of the app module instead of adding all the workspace modules as re-loadable.
The extension dependency filtering is extracted to a common utility class and applied to the IDE dev mode setup as well.
The logger in the DevMojo is now properly initialized.