Auto-detect container runtime #13669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gastaldi
force-pushed
the
detect_podman
branch
2 times, most recently
from
4dd3903 to
5f32dcd
Compare
jerboaa
reviewed
Dec 3, 2020
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
This checks that the podman or docker is chosen based on the environment
gastaldi
force-pushed
the
detect_podman
branch
from
5f32dcd to
0997ebf
Compare
zakkak
reviewed
Dec 4, 2020
| @@ -394,6 +397,51 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa | |||
| return nativeImage; | |||
| } | |||
|
|
|||
| /** | |||
| * @return {@link ContainerRuntime#PODMAN} if the podman executable exists in the environment or if the docker executable | |||
There was a problem hiding this comment.
The comment implies that podman is preferred over docker but the code does the opposite.
There was a problem hiding this comment.
Yeah, that was the initial behavior, but I changed later on and forgot to update the Javadoc 😛
|
While nice, this is a new feature, I won't backport it. |
|
Actually I think it's more like a bug fix than a new feature, but that's ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that podman or docker is chosen based on the environment
This is a follow-up to #10637 (comment)