Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing JpaRepository method deleteAllInBatch() #13618

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Implement missing JpaRepository method deleteAllInBatch() #13618

merged 1 commit into from
Dec 2, 2020

Conversation

renegrob
Copy link
Contributor

@renegrob renegrob commented Dec 2, 2020

This pull request implements the method JpaRepository.deleteAllInBatch() which currently throws a FunctionalityNotImplemented exception. I have to migrate a lot of test code which called this method and I thought it makes sense to implement it.

@ghost ghost added the area/spring Issues relating to the Spring integration label Dec 2, 2020
@gsmet gsmet requested a review from geoand December 2, 2020 10:16
geoand
geoand approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@geoand geoand marked this pull request as ready for review December 2, 2020 10:20
@renegrob renegrob force-pushed the implement-repository-method-delete-all-in-batch branch from c7272ef to 0563296 Compare December 2, 2020 10:47
@renegrob
Copy link
Contributor Author

renegrob commented Dec 2, 2020

@geoand

Caused by: io.fabric8.maven.docker.access.hc.http.HttpRequestException: {"message":"Get https://registry-1.docker.io/v2/microsoft/mssql-server-linux/manifests/2017-CU13: EOF"} (Internal Server Error: 500)

and

DOCKER> [docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.0] "elasticsearch": Timeout after 20454 ms while waiting on url http://localhost:9200

Shall I rebase again?

@geoand
Copy link
Contributor

geoand commented Dec 2, 2020

Shall I rebase again?

No need. If all the other jobs pass, I'll merge as this failure has nothing to do with your PR.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2020
@geoand geoand merged commit f763516 into quarkusio:master Dec 2, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 2, 2020
@renegrob renegrob deleted the implement-repository-method-delete-all-in-batch branch December 2, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/spring Issues relating to the Spring integration triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@renegrob @geoand