Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pom.xml changes in remote dev mode #12969

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Improve pom.xml changes in remote dev mode #12969

merged 1 commit into from
Oct 30, 2020

Conversation

stuartwdouglas
Copy link
Member

Fixes a few issues:

  • If startup fails the remote sync handler is not installed
  • If startup fails the default executor may not exist
  • The JDK client sends malformed q values (.2 instead of 0.2), resteasy rejects this with a bad request exception. This means that the 'restart probe' I was was using of GET '/' could fail, and the client would not reconnect.

Fixes #12497

@stuartwdouglas stuartwdouglas mentioned this pull request Oct 27, 2020
Closed
geoand
geoand approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like @cescoffier to take a look as well

cescoffier
cescoffier approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minors comments.

...ertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/RemoteSyncHandler.java Outdated
}, false, new Handler<AsyncResult<Object>>() {
@Override
public void handle(AsyncResult<Object> event) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can put null and not implement this handler (to be tested).

...ertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/RemoteSyncHandler.java Outdated
});
}, new Handler<AsyncResult<Object>>() {
@Override
public void handle(AsyncResult<Object> event) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, could be null I believe.
What about ordering? Do we need to preserve it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering does not matter.

@stuartwdouglas stuartwdouglas added this to the 1.10 - master milestone Oct 30, 2020
@stuartwdouglas stuartwdouglas merged commit 004cdd2 into quarkusio:master Oct 30, 2020
@AlanMasciangelo AlanMasciangelo mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging this pull request may close these issues.

Remote-dev with mutable jar throws connection errors
3 participants
@stuartwdouglas @cescoffier @geoand