Allow recording of immutable objects #10736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/core
area/dependencies
@RecordableConstructor can now be used to instruct the recoder to use a given constructor to create immutable objects. Also document the types that can be recorded. Fixes quarkusio#10150
|
@geoand care to have a look to that one? |
|
Yup, I'll take a look tomorrow |
geoand
reviewed
Jul 28, 2020
| @@ -454,6 +454,12 @@ | |||
| <artifactId>maven-resources-plugin</artifactId> | |||
| <version>3.1.0</version> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
Was this needed for some reason?
There was a problem hiding this comment.
Yes, so the way the immutable object recording works is that it maps field names to constructor parameter names. To actually record these names you need to use the -parameters javac option. Otherwise you would need annotations to specify the parameter names.
There was a problem hiding this comment.
👍
I was just wondering about the placement of this configuration (I did the review in the IDE and it seemed to not have updated the comment), not the functionality itself.
geoand
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RecordableConstructor can now be used to instruct the recoder
to use a given constructor to create immutable objects.
Also document the types that can be recorded.
Fixes #10150