Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-smallrye-jwt should provide JWT creation API #5341

Closed
sberyozkin opened this issue Nov 8, 2019 · 5 comments · Fixed by #6573
Closed

quarkus-smallrye-jwt should provide JWT creation API #5341

sberyozkin opened this issue Nov 8, 2019 · 5 comments · Fixed by #6573
Assignees
Labels
area/smallrye kind/enhancement New feature or request
Milestone

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Nov 8, 2019

Description
The users should use smallrye-jwt API to easily create JWTs to test or use when self-issued tokens are acceptable

Implementation ideas
smallrye-jwt will provide it, see smallrye/smallrye-jwt#137

@sberyozkin sberyozkin added kind/enhancement New feature or request area/smallrye labels Nov 8, 2019
@sberyozkin sberyozkin self-assigned this Nov 18, 2019
@sberyozkin sberyozkin added this to the 1.1.0 milestone Nov 18, 2019
@gsmet gsmet removed this from the 1.1.0 milestone Dec 6, 2019
@sberyozkin
Copy link
Member Author

sberyozkin commented Dec 9, 2019

See a new draft PR at smallrye/smallrye-jwt#158

@sbeigel
Copy link

sbeigel commented Jan 18, 2020

Great addition! But I think io.smallrye.jwt.build.impl.JwtProviderImpl (i.e. its no-args constructor) must be registered for reflection to be usable in native images:

Caused by: io.smallrye.jwt.build.JwtException: JwtProvider io.smallrye.jwt.build.impl.JwtProviderImpl could not be instantiated: java.lang.InstantiationException: Type io.smallrye.jwt.build.impl.JwtProviderImplcan not be instantiated reflectively as it does not have a no-parameter constructor or the no-parameter constructor has not been added explicitly to the native image.

As a workaround, I added an entry in my reflection config file.

@patoessy
Copy link

Congratulations for this, and helping smallrye's contributors implement this feature. I want to update the guides on JWT please someone give me direction.

@sberyozkin
Copy link
Member Author

@sbeigel it is a late comment, sorry, it has been fixed I believe in the latest releases.
@patoessy Hi, thanks, I still recall I promised to ping you to help with the docs, I've added a few, but I'm doing few more optimizations and once they are done and doc-ed I'll ping you for help to test and check the docs, cheers

@patoessy
Copy link

patoessy commented Jun 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smallrye kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants