Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move handling of NotFound http code from resteasy to the vertx-http extension #5236

Closed
machi1990 opened this issue Nov 5, 2019 · 5 comments · Fixed by #37680
Closed

Move handling of NotFound http code from resteasy to the vertx-http extension #5236

machi1990 opened this issue Nov 5, 2019 · 5 comments · Fixed by #37680
Assignees
Labels
area/devmode area/user-experience Will make us lose users kind/enhancement New feature or request
Milestone

Comments

@machi1990
Copy link
Member

Description
Current the NotFound error page is handled by resteasy via https://github.com/quarkusio/quarkus/blob/44e029ba5f100594f1fe235c63c3aee280f253b9/extensions/resteasy/runtime/src/main/java/io/quarkus/resteasy/runtime/NotFoundExceptionMapper.java.

This presents two setbacks:

  • We are unable to list vertx-web rest endpoints and various others endpoints eg swagger, metrics, health.
  • Also, if we change the http root path via quarkus.http.root-path to something else (other than /) and try to load localhost:8080/ we get Resource not found generated by vertx instead of the error page.

Implementation ideas

  • Add a DisplayableEndpointBuildItem.
  • add a 404 failure handler in vertx-http to intercept 404 http codes
  • make resteasy, undertow, vertx-web and spring-web and other extensions produce the build item so that can be propery consumed and listed from the vertx-http in case of a 404 error.

/cc @gsmet @stuartwdouglas .

@machi1990 machi1990 added kind/enhancement New feature or request area/user-experience Will make us lose users area/devmode labels Nov 5, 2019
@Dufgui
Copy link
Contributor

Dufgui commented Dec 7, 2019

hello. I am back and i will try this one.

@geoand
Copy link
Contributor

geoand commented Feb 26, 2024

@phillip-kruger I assume this is something you are working on?

@phillip-kruger
Copy link
Member

Yes, PR coming soon

@phillip-kruger phillip-kruger self-assigned this Feb 26, 2024
@geoand
Copy link
Contributor

geoand commented Feb 27, 2024

🥳

@phillip-kruger
Copy link
Member

Not ready yet, but it's all in this PR: #37680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode area/user-experience Will make us lose users kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants