Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: merge BlockingSender and Sender interfaces #44470

Closed
mkouba opened this issue Nov 13, 2024 · 0 comments · Fixed by #44474
Closed

WebSockets Next: merge BlockingSender and Sender interfaces #44470

mkouba opened this issue Nov 13, 2024 · 0 comments · Fixed by #44474
Assignees
@mkouba
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/websockets
Milestone
3.18 - main

Comments

@mkouba
Copy link
Contributor

mkouba commented Nov 13, 2024

Description

These interfaces are never used separately so it does not make a lot of sense to keep two classes.

I think that we should simplify the API and move all methods from BlockingSender to Sender and remove BlockingSender completely.

We want to keep the Sender interface though because of io.quarkus.websockets.next.WebSocketConnection.BroadcastSender.

Implementation ideas

No response
@mkouba mkouba added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/websockets labels Nov 13, 2024
@mkouba mkouba added this to the 3.18 - main milestone Nov 13, 2024
@mkouba mkouba self-assigned this Nov 13, 2024
@mkouba mkouba mentioned this issue Nov 13, 2024
Merged
@gsmet gsmet closed this as completed in acb1078 Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in WG - WebSocket Next Nov 13, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
@mkouba @bschuhmann
WebSockets Next: merge BlockingSender and Sender interfaces
2b91ed7 
- fixes quarkusio#44470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkouba mkouba

Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/websockets
Projects
WG - WebSocket Next
Status: Done
Milestone
3.18 - main
Development

Successfully merging a pull request may close this issue.

WebSockets Next: merge BlockingSender and Sender interfaces mkouba/quarkus
1 participant
@mkouba