JAVA_APP_DIR should be set for container images

[tadayosi]

Describe the bug

After upgrading Quarkus 3.5.2 -> 3.7.4, my container image built with jib container image extension starts to fail to run with the following error:

INFO exec -a "java" java -XX:MaxRAMPercentage=80.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:+ExitOnOutOfMemoryError -Djava.util.logging.manager=org.jboss.logmanager.LogManager -javaagent:lib/main/org.jolokia.jolokia-agent-jvm-2.0.1-javaagent.jar=protocol=https,host=*,port=8778,useSslClientAuthentication=true,caCert=/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt,clientPrincipal.1=cn=hawtio-online.hawtio.svc,extendedClientCheck=true,discoveryEnabled=false -cp "." -jar /home/jboss/quarkus-run.jar 
INFO running in /deployments
Error opening zip file or JAR manifest missing : lib/main/org.jolokia.jolokia-agent-jvm-2.0.1-javaagent.jar
Error occurred during initialization of VM
agent library failed to init: instrument

Looking at the container image changes by podman inspect, I noticed that the main difference is the change of entrypoint.

3.5.2: podman inspect <image> | jq .[].Config

  "Env": [
    "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
    "container=oci",
    "JAVA_DATA_DIR=/deployments/data",
    "JBOSS_CONTAINER_JAVA_JVM_MODULE=/opt/jboss/container/java/jvm",
    "JAVA_HOME=/usr/lib/jvm/jre",
    "JAVA_VENDOR=openjdk",
    "JBOSS_CONTAINER_OPENJDK_JRE_MODULE=/opt/jboss/container/openjdk/jre",
    "JBOSS_CONTAINER_JAVA_PROXY_MODULE=/opt/jboss/container/java/proxy",
    "JBOSS_IMAGE_VERSION=1.17",
    "LANG=C.utf8",
    "JBOSS_CONTAINER_UTIL_LOGGING_MODULE=/opt/jboss/container/util/logging/",
    "JBOSS_CONTAINER_JAVA_RUN_MODULE=/opt/jboss/container/java/run",
    "JAVA_VERSION=17",
    "HOME=/home/jboss",
    "JBOSS_IMAGE_NAME=ubi8/openjdk-17-runtime"
  ],
  "Entrypoint": [
    "java",
    "-Djava.util.logging.manager=org.jboss.logmanager.LogManager",
    "-javaagent:lib/main/org.jolokia.jolokia-agent-jvm-2.0.0-M4-agent.jar=protocol=https,host=*,port=8778,useSslClientAuthentication=true,caCert=/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt,clientPrincipal.1=cn=hawtio-online.hawtio.svc,extendedClientCheck=true,discoveryEnabled=false",
    "-jar",
    "quarkus-run.jar"
  ],

3.7.4: : podman inspect <image> | jq .[].Config

  "Env": [
    "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
    "container=oci",
    "GECOS=JBoss user",
    "JAVA_DATA_DIR=/deployments/data",
    "JBOSS_CONTAINER_JAVA_JVM_MODULE=/opt/jboss/container/java/jvm",
    "JAVA_HOME=/usr/lib/jvm/jre",
    "JAVA_VENDOR=openjdk",
    "JBOSS_CONTAINER_OPENJDK_JRE_MODULE=/opt/jboss/container/openjdk/jre",
    "JAVA_OPTS_APPEND=-Djava.util.logging.manager=org.jboss.logmanager.LogManager -javaagent:lib/main/org.jolokia.jolokia-agent-jvm-2.0.1-javaagent.jar=protocol=https,host=*,port=8778,useSslClientAuthentication=true,caCert=/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt,clientPrincipal.1=cn=hawtio-online.hawtio.svc,extendedClientCheck=true,discoveryEnabled=false",
    "USER=jboss",
    "JBOSS_CONTAINER_JAVA_PROXY_MODULE=/opt/jboss/container/java/proxy",
    "JBOSS_IMAGE_VERSION=1.18",
    "LANG=C.utf8",
    "UID=185",
    "JAVA_APP_JAR=/home/jboss/quarkus-run.jar",
    "JBOSS_CONTAINER_UTIL_LOGGING_MODULE=/opt/jboss/container/util/logging/",
    "JBOSS_CONTAINER_JAVA_RUN_MODULE=/opt/jboss/container/java/run",
    "JAVA_VERSION=17",
    "HOME=/home/jboss",
    "JBOSS_IMAGE_NAME=ubi8/openjdk-17-runtime"
  ],
  "Entrypoint": [
    "/opt/jboss/container/java/run/run-java.sh"
  ],

I think what lacks in 3.7.4 is:

JAVA_APP_DIR=/home/jboss

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @geoand (jib,kubernetes), @iocanel (kubernetes)

[tadayosi]

Indeed, when I run the image locally with:

podman run -e JAVA_APP_DIR=/home/jboss <image>

it starts to run again.

[geoand]

Thanks for reporting!

Can you give #39024 a try?

[tadayosi]

@geoand Thanks for your quick fix! Not easy for me to directly test your pull req at my end, but I tested that setting the env var really fixes the issue:

quarkus.jib.environment-variables.JAVA_APP_DIR=/home/jboss

[geoand]

Cool, I think that's enough :)