Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong logging of SpringCloudConfig server URL when using labels #38445

Closed
troosan opened this issue Jan 29, 2024 · 1 comment · Fixed by #38446
Closed

Wrong logging of SpringCloudConfig server URL when using labels #38445

troosan opened this issue Jan 29, 2024 · 1 comment · Fixed by #38446
Assignees
Labels
area/config area/spring Issues relating to the Spring integration kind/bug Something isn't working
Milestone

Comments

@troosan
Copy link
Contributor

troosan commented Jan 29, 2024

Describe the bug

The log statement that is supposed to print the final URL being called logs only the last segment only.

DEBUG [io.qu.sp.cl.co.cl.ru.VertxSpringCloudConfigGateway] (main) Attempting to read configuration from '/myLabel'.

instead of
DEBUG [io.qu.sp.cl.co.cl.ru.VertxSpringCloudConfigGateway] (main) Attempting to read configuration from 'http://myserver:8888/application-name/dev/myLabel'.

Expected behavior

log statement prints the whole URL

Actual behavior

only label is printed

How to Reproduce?

use spring cloud config with a label

Quarkus version or git rev

latest

Additional information

@radcortez The issue is here:

instead of appending to finalURI, it is replacing the value.

@troosan troosan added the kind/bug Something isn't working label Jan 29, 2024
troosan added a commit to troosan/quarkus that referenced this issue Jan 29, 2024
@radcortez radcortez added area/config area/spring Issues relating to the Spring integration and removed triage/needs-triage labels Jan 29, 2024
Copy link

quarkus-bot bot commented Jan 29, 2024

/cc @geoand (spring)

@radcortez radcortez self-assigned this Jan 29, 2024
@geoand geoand changed the title Wrong logging of SprintCloudConfig server URL when using labels Wrong logging of SpringCloudConfig server URL when using labels Jan 29, 2024
geoand added a commit that referenced this issue Jan 29, 2024
Append label instead of replacing whole Spring Cloud config URI
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 29, 2024
geoand added a commit to geoand/quarkus that referenced this issue Jan 29, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.1 Jan 30, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/spring Issues relating to the Spring integration kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants