Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for creation of non-compressed jars #38128

Closed
mavstuff opened this issue Jan 10, 2024 · 8 comments · Fixed by #38136
Closed

Allow for creation of non-compressed jars #38128

mavstuff opened this issue Jan 10, 2024 · 8 comments · Fixed by #38136
Labels
area/core kind/enhancement New feature or request
Milestone
3.7.0.CR1

Comments

@mavstuff
Copy link

Description

Please add option to tune uber-jar compression

Implementation ideas

No response
@mavstuff mavstuff added the kind/enhancement New feature or request label Jan 10, 2024
@geoand
Copy link
Contributor

geoand commented Jan 10, 2024

Could you please elaborate a little more about what you have in mind?

@geoand geoand added the triage/needs-feedback We are waiting for feedback. label Jan 10, 2024
@mavstuff
Copy link
Author

Could you please elaborate a little more about what you have in mind?

I have a Quarkus project that produces *-runner.jar and I was trying to disable compression for this jar to make some experiments. I found that setting compress=false for maven-jar-plugin does not affect the -runner.jar. The compression is set by quarkus-fs-util and is not adjustable.

@geoand
Copy link
Contributor

geoand commented Jan 10, 2024

Maybe I ask what the use case for an uncompressed jar is?

@geoand geoand removed the triage/needs-feedback We are waiting for feedback. label Jan 10, 2024
@mavstuff
Copy link
Author

Maybe I ask what the use case for an uncompressed jar is?

test the processing speed on a low-resource platform

@geoand
Copy link
Contributor

geoand commented Jan 10, 2024 •
edited
Loading

Understood.

I guess we could have a version of ZipUtils.newZip that allows the call site to pass in a custom env and we could populate that when building the jars (if necessary).

WDYT @aloubyansky? If you think it makes sense, I can go ahead and add it and then add a Quarkus property to control this.

@Sanne this is something you might interested in as well.

@aloubyansky
Copy link
Member

Sounds good to me, thanks!

@geoand geoand changed the title uber-jar compression Allow for creation of non-compressed jars Jan 10, 2024
@geoand
Copy link
Contributor

geoand commented Jan 10, 2024

Cool, I'll take care of this this week.

geoand added a commit to geoand/quarkus-fs-util that referenced this issue Jan 10, 2024
@geoand
Allow passing custom parameters when creating Zip FS
18994ac 
Relates to: quarkusio/quarkus#38128
@geoand geoand mentioned this issue Jan 10, 2024
Merged
geoand added a commit to geoand/quarkus-fs-util that referenced this issue Jan 10, 2024
@geoand
Allow passing custom parameters when creating Zip FS
a642e1f 
Relates to: quarkusio/quarkus#38128
geoand added a commit to geoand/quarkus-fs-util that referenced this issue Jan 10, 2024
@geoand
Allow passing custom parameters when creating Zip FS
e7e0779 
Relates to: quarkusio/quarkus#38128
geoand added a commit to geoand/quarkus-fs-util that referenced this issue Jan 10, 2024
@geoand
Allow passing custom parameters when creating Zip FS
2b9ed51 
Relates to: quarkusio/quarkus#38128
geoand added a commit to geoand/quarkus-fs-util that referenced this issue Jan 10, 2024
@geoand
Allow passing custom parameters when creating Zip FS
c125787 
Relates to: quarkusio/quarkus#38128
geoand added a commit to geoand/quarkus that referenced this issue Jan 11, 2024
@geoand
Introduce option to create uncompressed jars
1e992f1 
This is done by setting `quarkus.package.compress-jar`
to `false`.
This is a niche setting, but it can lead to slightly
reduced boot time when using uber-jar packaging

Closes: quarkusio#38128
@geoand geoand mentioned this issue Jan 11, 2024
Merged
@geoand
Copy link
Contributor

geoand commented Jan 11, 2024

#38136 adds this capability

geoand added a commit to geoand/quarkus that referenced this issue Jan 11, 2024
@geoand
Introduce option to create uncompressed jars
8926163 
This is done by setting `quarkus.package.compress-jar`
to `false`.
This is a niche setting, but it can lead to slightly
reduced boot time when using uber-jar packaging

Closes: quarkusio#38128
geoand added a commit to geoand/quarkus that referenced this issue Jan 11, 2024
@geoand
Introduce option to create uncompressed jars
95a069b 
This is done by setting `quarkus.package.compress-jar`
to `false`.
This is a niche setting, but it can lead to slightly
reduced boot time when using uber-jar packaging

Closes: quarkusio#38128
aloubyansky added a commit that referenced this issue Jan 11, 2024
@aloubyansky
Merge pull request #38136 from geoand/#38128
4d4f3a8 
Introduce option to create uncompressed jars
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Introduce option to create uncompressed jars geoand/quarkus
3 participants
@aloubyansky @geoand @mavstuff