Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestEasy Reactive warns when the endpoint returns JSON as String #38044

Closed
sberyozkin opened this issue Jan 4, 2024 · 1 comment · Fixed by #38049
Closed

RestEasy Reactive warns when the endpoint returns JSON as String #38044

sberyozkin opened this issue Jan 4, 2024 · 1 comment · Fixed by #38049
Labels
area/rest kind/bug Something isn't working
Milestone

Comments

@sberyozkin
Copy link
Member

Describe the bug

It is a minor one, I've been experimenting with Oidc Proxy (I need to experiment with OpenAI plugins) - this is a Quarkus JAX-RS endpoint which is presented as an OIDC provider which is implemented by delegating OIDC requests to the real provider such as Keycloak. For example, it returns a JSON containing various tokens and some other properties - it does not need to convert it to a bean, it is simply:

@Produces("application/json")
@GET
public String getJsonWebKeySet() {
}

I have 2 such methods and 2 warnings are generated, for example:

2024-01-04 17:26:24,362 WARN  [io.qua.res.rea.ser.dep.QuarkusServerEndpointIndexer] (build-74) Quarkus detected the use of JSON in JAX-RS method 'org.acme.security.openid.connect.plugin.OidcProxy#jwks' but no JSON extension has been added. Consider adding 'quarkus-resteasy-reactive-jackson' (recommended) or 'quarkus-resteasy-reactive-jsonb'.

The methods still work as expected without adding these extensions.

Expected behavior

Do not issue warning if the return type is String as it will be covered without having to add 'quarkus-resteasy-reactive-jackson' (or 'quarkus-resteasy-reactive-jsonb')

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@sberyozkin sberyozkin added the kind/bug Something isn't working label Jan 4, 2024
@quarkus-bot quarkus-bot bot added the area/rest label Jan 4, 2024
Copy link

quarkus-bot bot commented Jan 4, 2024

/cc @FroMage (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

geoand added a commit to geoand/quarkus that referenced this issue Jan 5, 2024
gsmet added a commit that referenced this issue Jan 5, 2024
Don't warn about missing JSON when returning String
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 5, 2024
@gsmet gsmet modified the milestones: 3.7 - main, 3.6.5 Jan 9, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants