Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-tests/kafka-sasl-elytron tests modify files in src/test/resources #38002

Closed
gsmet opened this issue Jan 3, 2024 · 3 comments · Fixed by #38004
Closed

integration-tests/kafka-sasl-elytron tests modify files in src/test/resources #38002

gsmet opened this issue Jan 3, 2024 · 3 comments · Fixed by #38004
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Jan 3, 2024

When executing the tests in integration-tests/kafka-sasl-elytron, we end up with the following git status:

On branch main
Your branch and 'origin/main' have diverged,
and have 623 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   src/test/resources/client.keytab
	modified:   src/test/resources/kafkabroker.keytab

Resources committed to the Git repository shouldn't be modified by the tests, this needs fixing.

Copy link

quarkus-bot bot commented Jan 3, 2024

/cc @alesj (kafka), @cescoffier (kafka), @ozangunalp (kafka)

@gsmet
Copy link
Member Author

gsmet commented Jan 3, 2024

@ozangunalp could you have a look at this? I fear it might end up breaking some workflow somewhere.

@ozangunalp
Copy link
Contributor

@gsmet ok! I think I know the fix, let me look at this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants