HotDeploymentWatchedFileBuildItem predicate not working when auto-build is enabled (vscode)

[ia3andy]

Describe the bug

Currently, Quarkus is looking for modification between the target and the source (when using a HotDeploymentWatchedFileBuildItem.locationPredicate):
https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java#L913-L914

When using a static location, then it compare a timestamp registered locally (which works):
https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java#L968

When auto-build is enabled (vscode), the target file and the source file are the same after a modification and the change is not detected by Quarkus.

Expected behavior

Change should be detected with the HotDeploymentWatchedFileBuildItem.locationPredicate

Actual behavior

Change is not detected

How to Reproduce?

https://github.com/ia3andy/web-bundler-jquery

Open with vscode (java enabled), start dev mode and change something in src/main/resources/web/... (reload)

[ia3andy]

cc @mkouba

[mkouba]

Hm, I wonder if this could ever work... anyway, I'll take a look next Monday.

[ia3andy]

@mkouba maybe we should fill the timestampSet.watchedFileTimestamps with the resources matching the predicate at startup.

[mkouba]

So I looked into the code and it worked in my test by coincidence 🤦. A HotDeploymentWatchedFileBuildItem with a predicate is only considered when a new file is created. In my test this solved the problem with a new template added to the app because subsequent restarts were handled by the location-based HotDeploymentWatchedFileBuildItem produced by the Qute extension.

maybe we should fill the timestampSet.watchedFileTimestamps with the resources matching the predicate at startup.

Yes, something like that. But I need to look at the code again. It's not exactly straightforward.

[ia3andy]

Thanks @mkouba this was an adventure :)

[ia3andy]

@fbricon this is fixing the bug you experienced on vscode :)