Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift deployment config properties all start with get-/is- #35594

Closed
yrodiere opened this issue Aug 28, 2023 · 7 comments · Fixed by #35618
Closed

Openshift deployment config properties all start with get-/is- #35594

yrodiere opened this issue Aug 28, 2023 · 7 comments · Fixed by #35618
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@yrodiere
Copy link
Member

Describe the bug

In the documentation at least, it seems config properties are broken, as they all start with get-/is-:

See screenshot from the documentation of the main branch:

image

Branch 3.3 seems affected as well, not sure about 3.2. 2.x isn't affected for sure.

I'm not sure whether this is just a documentation problem, or if configuration properties are actually broken.

Expected behavior

No weird get-/is- prefixes.

Actual behavior

Weird get-/is- prefixes.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@yrodiere yrodiere added the kind/bug Something isn't working label Aug 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2023

/cc @geoand (openshift), @iocanel (openshift)

@yrodiere
Copy link
Member Author

@gsmet
Copy link
Member

gsmet commented Aug 28, 2023

@radcortez that's probably another one for you?

@gsmet
Copy link
Member

gsmet commented Aug 28, 2023

The particularity of this config is that there are getters in it. And that might conflict with the detecting of the new @ConfigMapping stuff.

I'll have a look to see if I can figure out how to work around it.

@yrodiere
Copy link
Member Author

Note this seems to impact other, related extensions, e.g. the Kubernetes one: https://quarkus.io/guides/deploying-to-kubernetes#quarkus-kubernetes-kubernetes-config_quarkus.kubernetes.get-env.secrets

@gsmet
Copy link
Member

gsmet commented Aug 28, 2023

Yeah, I noticed that.

gsmet added a commit to gsmet/quarkus that referenced this issue Aug 29, 2023
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 29, 2023
Noticed while working on another approach to fix quarkusio#35594.
@gsmet
Copy link
Member

gsmet commented Aug 29, 2023

I created a PR here: #35618 .

It also affects 3.2.

@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 29, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.2 Sep 4, 2023
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 4, 2023
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 4, 2023
Noticed while working on another approach to fix quarkusio#35594.

(cherry picked from commit 8dc1754)
@gsmet gsmet modified the milestones: 3.3.2, 3.2.7.Final Oct 3, 2023
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 3, 2023
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 3, 2023
Noticed while working on another approach to fix quarkusio#35594.

(cherry picked from commit 8dc1754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants