Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should SafeVertxContextInterceptor define a Priority? #35173

Closed
gsmet opened this issue Aug 2, 2023 · 4 comments · Fixed by #35175
Closed

Should SafeVertxContextInterceptor define a Priority? #35173

gsmet opened this issue Aug 2, 2023 · 4 comments · Fixed by #35175
Labels
area/arc Issue related to ARC (dependency injection)
Milestone
3.3.0.CR1

Comments

@gsmet
Copy link
Member

gsmet commented Aug 2, 2023

When running the tests in integration-tests/grpc-mutual-auth, I get the following log line:

2023-08-02 18:05:06,718 INFO [io.qua.arc.pro.Interceptors] (build-15) The interceptor io.quarkus.vertx.core.runtime.context.SafeVertxContextInterceptor does not declare any @priority. It will be assigned a default priority value of 0.

Could we get rid of it?

@mkouba in the absence of @cescoffier, I'm pinging you.
@mkouba
Copy link
Contributor

mkouba commented Aug 2, 2023

Ah, yes, we should add the @Priotity(0). I will send a pull request shortly.

@mkouba
Copy link
Contributor

mkouba commented Aug 2, 2023

In fact, I think that we should also move the io.quarkus.vertx.core.runtime.context.SafeVertxContext annotation to the io.quarkus.vertx package because io.quarkus.vertx.core.runtime.context should not be considered part of the public API.

@gsmet
Copy link
Member Author

gsmet commented Aug 2, 2023

It absolutely should not :)

mkouba added a commit to mkouba/quarkus that referenced this issue Aug 2, 2023
@mkouba
Vertx: add priority to the SafeVertxContextInterceptor
6b30485 
- also move the SafeVertxContext binding to the io.quarkus.vertx package
because io.quarkus.vertx.core.runtime.context should not be considered
part of the public API
- fixes quarkusio#35173
@mkouba mkouba mentioned this issue Aug 2, 2023
Merged
@geoand geoand added area/arc Issue related to ARC (dependency injection) and removed triage/needs-triage labels Aug 3, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2023

/cc @Ladicek (arc), @manovotn (arc)

mkouba added a commit to mkouba/quarkus that referenced this issue Aug 4, 2023
@mkouba
Vertx: add priority to the SafeVertxContextInterceptor
25aeaac 
- also move the SafeVertxContext binding to the io.quarkus.vertx package
because io.quarkus.vertx.core.runtime.context should not be considered
part of the public API
- fixes quarkusio#35173
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging a pull request may close this issue.

Vertx: add priority to the SafeVertxContextInterceptor mkouba/quarkus
3 participants
@mkouba @gsmet @geoand