-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agroal does not provide existing connections from the pool when new connections cannot be established and pool<MIN_SIZE #31246
Comments
thanks @sschu. The issue on the Agroal side is https://issues.redhat.com/projects/AG/issues/AG-201 |
As far as I can see, the fix for the connection problem was merged and the Jira issue resolved: |
We're using 2.0 at the moment in Quarkus. 2.1 was released just 15 hours ago, let's give @barreiro some time to update it in Quarkus ;) |
I'm counting on dependabot to trigger the update. Usually doesn't take long. |
Will this be backported to Quarkus 2.13 (for Keycloak)? |
@Sanne triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request.
|
@sschu good idea - labelled it. |
@Sanne Since the bot wouldn't create a PR, I did: #31761 |
Fixes quarkusio#31246 (cherry picked from commit 32cfabd)
Describe the bug
Expected behavior
GIVEN there are database connection problems
AND the current number of connections is below MIN_SIZE
AND there are still valid connections in the pool
AND new connections cannot be created
WHEN a connection is requested from the pool
THEN then an existing connection from the pool is returned and the request succeeds
Actual behavior
GIVEN there are database connection problems
AND the current number of connections is below MIN_SIZE
AND there are still valid connections in the pool
AND new connections cannot be created
WHEN a connection is requested from the pool
THEN no connection can be obtained and the request fails
How to Reproduce?
We reproduced the behaviour by changing the db password on a running application so the pool cannot create new connections and killing existing db sessions to bring the number of connections below MIN_SIZE.
However, the problem can be seen directly in the code: https://github.com/agroal/agroal/blob/4c4da6419652f772542e648581d0d8939c411b5e/agroal-pool/src/main/java/io/agroal/pool/ConnectionPool.java#L270-L323
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: